From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH] block/aio: Enable sysfs nomerge control for I/O requests in the plug list Date: Wed, 23 Oct 2013 17:10:38 +0100 Message-ID: <20131023161038.GI14598@kernel.dk> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alireza Haghdoost , linux-kernel@vger.kernel.org, Jerry Fredin , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org To: Jeff Moyer Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-aio@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Oct 23 2013, Jeff Moyer wrote: > Alireza Haghdoost writes: > > > This patch enables the sysfs to control I/O request merge > > functionality in the plug list. While this control has been > > implemented for the request queue, it was dismissed in the plug list. > > Therefore, block layer merges requests together (or attempt to merge) > > even if the merge capability was disable using sysfs nomerge parameter > > value 2. > > Yeah, this looks like an oversight. Your mailer really munged up the > patch, though. You should fix that and resend (unless Jens just fixes > it up manually). Also, please specify the -p option to diff or just use > git diff. I fixed it up, changed the style slightly as well (no point in reading and checking the plug first). This is what I queued up: http://git.kernel.dk/?p=linux-block.git;a=commit;h=dfc302d833c46f40b5f775099da00bb0cf0e81ad -- Jens Axboe -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: aart@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752770Ab3JWQKv (ORCPT ); Wed, 23 Oct 2013 12:10:51 -0400 Received: from merlin.infradead.org ([205.233.59.134]:50244 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752542Ab3JWQKu (ORCPT ); Wed, 23 Oct 2013 12:10:50 -0400 Date: Wed, 23 Oct 2013 17:10:38 +0100 From: Jens Axboe To: Jeff Moyer Cc: Alireza Haghdoost , linux-kernel@vger.kernel.org, Jerry Fredin , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] block/aio: Enable sysfs nomerge control for I/O requests in the plug list Message-ID: <20131023161038.GI14598@kernel.dk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 23 2013, Jeff Moyer wrote: > Alireza Haghdoost writes: > > > This patch enables the sysfs to control I/O request merge > > functionality in the plug list. While this control has been > > implemented for the request queue, it was dismissed in the plug list. > > Therefore, block layer merges requests together (or attempt to merge) > > even if the merge capability was disable using sysfs nomerge parameter > > value 2. > > Yeah, this looks like an oversight. Your mailer really munged up the > patch, though. You should fix that and resend (unless Jens just fixes > it up manually). Also, please specify the -p option to diff or just use > git diff. I fixed it up, changed the style slightly as well (no point in reading and checking the plug first). This is what I queued up: http://git.kernel.dk/?p=linux-block.git;a=commit;h=dfc302d833c46f40b5f775099da00bb0cf0e81ad -- Jens Axboe