All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: elementary d_move question
Date: Wed, 23 Oct 2013 13:27:48 -0400	[thread overview]
Message-ID: <20131023172748.GF30796@fieldses.org> (raw)

(Bah, apologies, I messed up the list cc.  Resending in case it's useful
to have the answer in the archives.)

On Wed, Oct 23, 2013 at 01:23:38PM -0400, J. Bruce Fields wrote:
> On Wed, Oct 23, 2013 at 05:14:02PM +0100, Al Viro wrote:
> > On Wed, Oct 23, 2013 at 11:43:41AM -0400, J. Bruce Fields wrote:
> > 
> > > The rename does a d_move(dentry, target) where I assume dentry is for
> > > "foo" and target for "bar", with target the same dentry that the file
> > > descriptor holds a reference on.
> > > 
> > > But d_move() does
> > > 
> > > 	switch_names(dentry, target);
> > 
> > Yes
> > 
> > > giving target name "foo"
> > 
> > Not really.  Check what it does when both names are inline ones (i.e.
> > shorter than 32 characters and stored in struct dentry itself)...
> 
> Doh--got it, thanks!
> 
> I have a feeling I've gotten lost here before.
> 
> I assume it's just never seemed worth the trouble to make the readlink
> string more consistent given that its value's not really well-defined
> anyway, OK.
> 
> --b.

             reply	other threads:[~2013-10-23 17:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-23 17:27 J. Bruce Fields [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-10-23 15:46 elementary d_move question J. Bruce Fields
2013-10-29 16:28 ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131023172748.GF30796@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.