From: Fengguang Wu <fengguang.wu@intel.com>
To: Christoph Paasch <christoph.paasch@uclouvain.be>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: -27% netperf TCP_STREAM regression by "tcp_memcontrol: Kill struct tcp_memcontrol"
Date: Wed, 23 Oct 2013 23:07:43 +0100 [thread overview]
Message-ID: <20131023220743.GA5226@localhost> (raw)
In-Reply-To: <20131023122543.GH5132@cpaasch-mac>
> - return !!sk->sk_prot->memory_pressure;
> + return !!*sk->sk_prot->memory_pressure;
Good catch, Christoph! With no surprise, it restores the performance:
a4fe34bf902b8f709c63 2e685cad57906e19add7 a235435d612680e595ea
------------------------ ------------------------ ------------------------
707.40 -41.0% 417.50 -8.8% 645.00 lkp-nex04/micro/netperf/120s-200%-TCP_STREAM
2775.60 -23.7% 2116.50 +2.1% 2834.00 lkp-sb03/micro/netperf/120s-200%-TCP_STREAM
3483.00 -27.2% 2534.00 -0.1% 3479.00 TOTAL netperf.Throughput_Mbps
It's a bit late, but
Tested-by: Fengguang Wu <fengguang.wu@intel.com>
Thanks,
Fengguang
prev parent reply other threads:[~2013-10-23 22:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 21:41 -27% netperf TCP_STREAM regression by "tcp_memcontrol: Kill struct tcp_memcontrol" fengguang.wu
2013-10-22 22:00 ` David Miller
2013-10-23 4:38 ` Eric W. Biederman
2013-10-23 6:10 ` Fengguang Wu
2013-10-23 9:43 ` Eric W. Biederman
2013-10-23 11:46 ` Fengguang Wu
2013-10-23 12:25 ` Christoph Paasch
2013-10-23 13:02 ` Eric Dumazet
2013-10-23 19:55 ` [PATCH] Fix: Dereference pointer-value of sk_prot->memory_pressure Eric W. Biederman
2013-10-23 20:15 ` David Miller
2013-10-23 19:58 ` Eric W. Biederman
2013-10-23 22:07 ` Fengguang Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131023220743.GA5226@localhost \
--to=fengguang.wu@intel.com \
--cc=christoph.paasch@uclouvain.be \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.