From: Nicolin Chen <b42378@freescale.com>
To: alsa-devel@alsa-project.org
Cc: broonie@kernel.org
Subject: Is that reasonable to support pinctrl PM in ASoC core?
Date: Thu, 24 Oct 2013 19:07:43 +0800 [thread overview]
Message-ID: <20131024110743.GD8385@MrMyself> (raw)
Hi all,
It's quite popular that more drivers are using pinctrl PM, for example:
(Documentation/devicetree/bindings/arm/primecell.txt). Just like what
runtime PM does, it would de-active and en-active pin group depending
on whether it's being used or not.
And I think this pinctrl PM might be also beneficial to cpu dai drivers
since they might have actual pins, and they can hypnotize/wake them up
along with runtime PM:
@@ -183,6 +183,7 @@ static int soc_pcm_open(struct snd_pcm_substream *substream)
struct snd_soc_dai_driver *codec_dai_drv = codec_dai->driver;
int ret = 0;
+ pinctrl_pm_select_default_state(cpu_dai->dev);
pm_runtime_get_sync(cpu_dai->dev);
pm_runtime_get_sync(codec_dai->dev);
pm_runtime_get_sync(platform->dev);
As pinctrl PM is also reference counted and would return 0 if there
is no pinctrl settings, this would not break current ASoC subsystem
and any cpu dai driver.
So I just want to ask if it's reasonable to add it. Or another one:
is there anything similar to sleep pins? Although I've searched the
whole ./sound directory, it seems no drivers under it is using this
pinctrl PM.
Best regards,
Nicolin Chen
next reply other threads:[~2013-10-24 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 11:07 Nicolin Chen [this message]
2013-10-24 11:52 ` Is that reasonable to support pinctrl PM in ASoC core? Mark Brown
2013-10-24 13:19 ` Linus Walleij
2013-10-24 14:15 ` Mark Brown
2013-10-25 2:21 ` Nicolin Chen
2013-10-25 10:00 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024110743.GD8385@MrMyself \
--to=b42378@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.