All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dwight Engen <dwight.engen@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: xfstest 318
Date: Thu, 24 Oct 2013 13:05:28 -0400	[thread overview]
Message-ID: <20131024130528.37c2c44e@oracle.com> (raw)
In-Reply-To: <20131024154414.GB19055@infradead.org>

On Thu, 24 Oct 2013 08:44:14 -0700
Christoph Hellwig <hch@infradead.org> wrote:

> This test has always been failing for me on my Debian stable system
> with the output below, any idea why this could be?

Looks like the | getfacl_filter_id isn't doing any good on the getfacl
that is being run in the userns because the uids don't match $acl[12]
(which is the point), and the uids that _acl_setup_ids picked are not
the same distance apart as they were on my system. So on your system
$acl2 is not $acl1 + 1.

Let me see about running the second getfacl through a filter that knows
how to replace it based on the delta between $acl1 and $acl2, I think
that should always work.

> --- tests/generic/318.out	2013-09-09 14:41:08.000000000 +0000
> +++ /root/xfstests/results//generic/318.out.bad	2013-10-24
> 15:44:01.000000000 +0000 @@ -17,7 +17,7 @@
>  # group: 65534
>  user::rw-
>  user:0:r-x	#effective:r--
> -user:1:rw-	#effective:r--
> +user:3:rw-	#effective:r--
>  group::r--
>  group:0:--x	#effective:---
>  mask::r--
> @@ -43,7 +43,7 @@
>  # group: 65534
>  user::rw-
>  user:0:r-x	#effective:r--
> -user:1:rw-	#effective:r--
> +user:3:rw-	#effective:r--
>  group::r--
>  group:0:--x	#effective:---
>  mask::r--

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-10-24 17:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-24 15:44 xfstest 318 Christoph Hellwig
2013-10-24 17:05 ` Dwight Engen [this message]
2013-10-24 20:11 ` [PATCH] xfstests: generic/318 use symbolic namespaced ids Dwight Engen
2013-10-25  9:31   ` Christoph Hellwig
2013-11-04 20:11     ` Rich Johnston
2013-11-04 20:21       ` Rich Johnston
2013-11-04 20:25   ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131024130528.37c2c44e@oracle.com \
    --to=dwight.engen@oracle.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.