From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
Jeff King <peff@peff.net>, GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] http.c: Spell the null pointer as NULL
Date: Thu, 24 Oct 2013 13:58:17 -0700 [thread overview]
Message-ID: <20131024205817.GD9464@google.com> (raw)
In-Reply-To: <5269804F.2080800@ramsay1.demon.co.uk>
Ramsay Jones wrote:
> Commit 1bbcc224 ("http: refactor options to http_get_*", 28-09-2013)
> changed the type of final 'options' argument of the http_get_file()
> function from an int to an 'struct http_get_options' pointer.
> However, it neglected to update the (single) call site. Since this
> call was passing '0' to that argument, it was (correctly) being
> interpreted as a null pointer. Change to argument to NULL.
Jeff King wrote:
> Thanks, patch is obviously correct (and the cause was just oversight on
> my part).
For what it's worth, against the jk/http-auth-redirects branch,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
next prev parent reply other threads:[~2013-10-24 20:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 20:17 [PATCH] http.c: Spell the null pointer as NULL Ramsay Jones
2013-10-24 20:58 ` Jonathan Nieder [this message]
2013-10-24 21:42 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2013-10-15 21:55 Ramsay Jones
2013-10-15 22:03 ` Jeff King
2013-10-15 23:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024205817.GD9464@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.