From: Florian Westphal <fw@strlen.de>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] bridge: netfilter: orphan skb before invoking ip netfilter hooks
Date: Thu, 24 Oct 2013 23:00:23 +0200 [thread overview]
Message-ID: <20131024210023.GA6543@breakpoint.cc> (raw)
In-Reply-To: <1382645650.7572.68.camel@edumazet-glaptop.roam.corp.google.com>
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Thu, 2013-10-24 at 21:32 +0200, Florian Westphal wrote:
> > Pekka Pietikäinen reports xt_socket behavioural change after commit
>
> behavioral maybe ? ;)
AE vs. BE i guess. I grep'd /usr/share/dict/* before, i swear ;)
> > 00028aa37098o (netfilter: xt_socket: use IP early demux).
> >
> > Reason is xt_socket now no longer does an unconditional sk lookup -
> > it re-uses existing skb->sk if possible, assuming ->sk was set by
> > tcp early demux.
>
> s/tcp/ip/ since it also can work for UDP sockets in net-next
True. Pablo, could you amend this bit if you decide to apply this
to -next tree (i guess -next is fine)?
Thanks for reviewing this Eric!
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-10-24 21:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 19:32 [PATCH] bridge: netfilter: orphan skb before invoking ip netfilter hooks Florian Westphal
2013-10-24 20:14 ` Eric Dumazet
2013-10-24 21:00 ` Florian Westphal [this message]
2013-10-27 20:46 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024210023.GA6543@breakpoint.cc \
--to=fw@strlen.de \
--cc=eric.dumazet@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.