From: Jens Axboe <axboe@kernel.dk>
To: Joe Perches <joe@perches.com>
Cc: Ramprasad Chinthekindi <Ramprasad.Chinthekindi@hgst.com>,
Akhil Bhansali <Akhil.Bhansali@hgst.com>,
"jmoyer@redhat.com" <jmoyer@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Amit Phansalkar <Amit.Phansalkar@hgst.com>
Subject: Re: [PATCH] skd: Replaced custom debug PRINTKs with pr_debug
Date: Fri, 25 Oct 2013 12:24:30 +0100 [thread overview]
Message-ID: <20131025112430.GE6285@kernel.dk> (raw)
In-Reply-To: <1382627375.22433.58.camel@joe-AO722>
On Thu, Oct 24 2013, Joe Perches wrote:
> On Thu, 2013-10-24 at 12:53 +0100, Jens Axboe wrote:
> > On Thu, Oct 24 2013, Ramprasad Chinthekindi wrote:
> > > Hi Jens,
> > >
> > > I'm resending the patch to replace custom debug macros with
> > > pr_debug(). Kindly please review and apply the patch. Thanking you.
> >
> > Thanks, that's a nice improvement. Applied.
>
> Is it really much of an improvement?
>
> It leaves possible different behavior with
> skdev->dbg_level/skd_dbg_level set without
> linkage to a few printks now.
>
> It also doesn't make use of dynamic debug's
> +f/+l capability to and always emits
> __func__/__LINE__.
It's an improvement from a private FOOPRINTK() macro. Feel free to send
in further improvements.
--
Jens Axboe
next prev parent reply other threads:[~2013-10-25 11:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 11:47 [PATCH] skd: Replaced custom debug PRINTKs with pr_debug Ramprasad Chinthekindi
2013-10-24 11:53 ` Jens Axboe
2013-10-24 15:09 ` Joe Perches
2013-10-25 11:24 ` Jens Axboe [this message]
2013-10-25 15:05 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131025112430.GE6285@kernel.dk \
--to=axboe@kernel.dk \
--cc=Akhil.Bhansali@hgst.com \
--cc=Amit.Phansalkar@hgst.com \
--cc=Ramprasad.Chinthekindi@hgst.com \
--cc=jmoyer@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.