From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Date: Fri, 25 Oct 2013 09:39:02 +0000 Subject: Re: [PATCH ipvs 1/2] net: ipvs: sctp: add missing verdict assignments in sctp_conn_schedule Message-Id: <20131025113902.2d8dd9d0@redhat.com> List-Id: References: <1af1d5e1aae9df91683625f0cb120b329e8d2f10.1382689350.git.dborkman@redhat.com> In-Reply-To: <1af1d5e1aae9df91683625f0cb120b329e8d2f10.1382689350.git.dborkman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sctp@vger.kernel.org On Fri, 25 Oct 2013 11:05:04 +0200 Daniel Borkmann wrote: > If skb_header_pointer() fails, we need to assign a verdict, that is > NF_DROP in this case, otherwise, we would leave the verdict from > conn_schedule() uninitialized when returning. > > Signed-off-by: Daniel Borkmann > --- Acked-by: Jesper Dangaard Brouer It looks like a good ide, and resembles how we handle these situations else were in the IPVS code (e.g. for TCP and UDP). -- Best regards, Jesper Dangaard Brouer MSc.CS, Sr. Network Kernel Developer at Red Hat Author of http://www.iptv-analyzer.org LinkedIn: http://www.linkedin.com/in/brouer From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [PATCH ipvs 1/2] net: ipvs: sctp: add missing verdict assignments in sctp_conn_schedule Date: Fri, 25 Oct 2013 11:39:02 +0200 Message-ID: <20131025113902.2d8dd9d0@redhat.com> References: <1af1d5e1aae9df91683625f0cb120b329e8d2f10.1382689350.git.dborkman@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1af1d5e1aae9df91683625f0cb120b329e8d2f10.1382689350.git.dborkman@redhat.com> Sender: lvs-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Daniel Borkmann Cc: horms@verge.net.au, lvs-devel@vger.kernel.org, linux-sctp@vger.kernel.org On Fri, 25 Oct 2013 11:05:04 +0200 Daniel Borkmann wrote: > If skb_header_pointer() fails, we need to assign a verdict, that is > NF_DROP in this case, otherwise, we would leave the verdict from > conn_schedule() uninitialized when returning. > > Signed-off-by: Daniel Borkmann > --- Acked-by: Jesper Dangaard Brouer It looks like a good ide, and resembles how we handle these situations else were in the IPVS code (e.g. for TCP and UDP). -- Best regards, Jesper Dangaard Brouer MSc.CS, Sr. Network Kernel Developer at Red Hat Author of http://www.iptv-analyzer.org LinkedIn: http://www.linkedin.com/in/brouer