From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [git pull] a couple of fixes for rc7
Date: Fri, 25 Oct 2013 15:56:25 +0100 [thread overview]
Message-ID: <20131025145625.GF13318@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+55aFx2XQvf1pbhoRP7EJL=We04d3E0i0-DY3gCfcqv7T76Hg@mail.gmail.com>
On Fri, Oct 25, 2013 at 03:33:46PM +0100, Linus Torvalds wrote:
> On Fri, Oct 25, 2013 at 3:25 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> > nfsd performance regression fix + seq_file lseek(2) fix.
> > Please, pull from the usual place -
> > git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus
>
> Not acceptable.
>
> fs/file_table.c: In function ???fput???:
> fs/file_table.c:320:4: warning: passing argument 1 of
> ???schedule_delayed_work??? from incompatible pointer type [enabled by
> default]
> schedule_delayed_work(&delayed_fput_work, 1);
> ^
> In file included from include/linux/srcu.h:34:0,
> from include/linux/notifier.h:15,
> from include/linux/memory_hotplug.h:6,
> from include/linux/mmzone.h:797,
> from include/linux/gfp.h:4,
> from include/linux/slab.h:14,
> from fs/file_table.c:9:
> include/linux/workqueue.h:594:60: note: expected ???struct delayed_work
> *??? but argument is of type ???struct work_struct *???
> static inline bool schedule_delayed_work(struct delayed_work *dwork,
>
> Plase stop sending me untested crap that doesn't even compile cleanly!
Oh, hell... git cherry-pick (for the wrong place, at that) instead of just
pushing the bugger as it was - it sat on top of previous vfs.git#for-linus.
Mea culpa ;-/
I've pushed the right branch now; should propagate in a few minutes.
Head should be at 05e16745c.
prev parent reply other threads:[~2013-10-25 14:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 14:25 [git pull] a couple of fixes for rc7 Al Viro
2013-10-25 14:33 ` Linus Torvalds
2013-10-25 14:56 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131025145625.GF13318@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.