Re: [PATCH] dcache: fix outdated DCACHE_NEED_LOOKUP comment

["J. Bruce Fields" <bfields@fieldses.org>]

Also added to the "for-viro" branch at:

	git://linux-nfs.org/~bfields/linux.git for-viro

Which now includes:

	- the delegation patches
	- 32/64-bit filehandle lookup fix
	- 4 dcache patches fixing some uses of DCACHE_DISCONECTED.

All previously posted.

--b.


On Fri, Oct 25, 2013 at 11:59:15AM -0400, bfields wrote:
> From: "J. Bruce Fields" <bfields@redhat.com>
> 
> The DCACHE_NEED_LOOKUP case referred to here was removed with
> 39e3c9553f34381a1b664c27b0c696a266a5735e "vfs: remove
> DCACHE_NEED_LOOKUP".
> 
> There are only four real_lookup() callers and all of them pass in an
> unhashed dentry just returned from d_alloc.
> 
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
> ---
>  fs/namei.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/namei.c b/fs/namei.c
> index e337f45..b83bf27 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -1308,8 +1308,8 @@ static struct dentry *lookup_dcache(struct qstr *name, struct dentry *dir,
>  }
>  
>  /*
> - * Call i_op->lookup on the dentry.  The dentry must be negative but may be
> - * hashed if it was pouplated with DCACHE_NEED_LOOKUP.
> + * Call i_op->lookup on the dentry.  The dentry must be negative and
> + * unhashed.
>   *
>   * dir->d_inode->i_mutex must be held
>   */
> -- 
> 1.7.9.5
>