From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH 11/11] newuidmap,newgidmap: New suid helpers for using subordinate uids and gids Date: Fri, 25 Oct 2013 20:30:25 +0000 Message-ID: <20131025203025.GA2467@mail.hallyn.com> References: <87d2wxshu0.fsf@xmission.com> <87ehhdpoag.fsf@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <87ehhdpoag.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Eric W. Biederman" Cc: Linux Containers , Pkg-shadow-devel-XbBxUvOt3X2LieD7tvxI8l/i77bcL1HB@public.gmane.org, "Michael Kerrisk (man-pages)" , Nicolas =?iso-8859-1?Q?Fran=E7ois?= List-Id: containers.vger.kernel.org Quoting Eric W. Biederman (ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org): Hi, > +static bool verify_range(struct passwd *pw, struct map_range *range) > +{ > + /* An empty range is invalid */ > + if (range->count == 0) > + return false; > + > + /* Test /etc/subuid */ > + if (have_sub_uids(pw->pw_name, range->lower, range->count)) > + return true; I think the have_sub_uids() test should be skipped if we started out as root. Is there a reason not to do that? -serge