From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Sachin Kamat <sachin.kamat@linaro.org>,
linux-kernel@vger.kernel.org, dwmw2@infradead.org
Subject: Re: [PATCH v3 1/4] ab8500-charger: Check return value of regulator_enable
Date: Fri, 25 Oct 2013 15:37:45 -0700 [thread overview]
Message-ID: <20131025223745.GA1157@teo> (raw)
In-Reply-To: <20130906093800.GF32654@lee--X1>
On Fri, Sep 06, 2013 at 10:38:00AM +0100, Lee Jones wrote:
> On Fri, 06 Sep 2013, Sachin Kamat wrote:
>
> > Check the return value of regulator_enable to silence the following
> > type of warnings:
> > drivers/power/ab8500_charger.c:1390:20: warning: ignoring return value
> > of ‘regulator_enable’, declared with attribute warn_unused_result
> > [-Wunused-result]
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > ---
> > Compile tested.
> >
> > Changes since v2:
> > * removed redundant assignment to false.
> > Changes since v1:
> > * converted dev_err and return to dev_warn as suggested by Lee Jones.
> > ---
> >
> > drivers/power/ab8500_charger.c | 16 ++++++++++++----
> > 1 file changed, 12 insertions(+), 4 deletions(-)
>
> Looks good now.
>
> Acked-by: Lee Jones <lee.jones@linaro.org>
Applied, thanks a lot for the patches and reviews!
Anton
prev parent reply other threads:[~2013-10-25 22:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 8:01 [PATCH v3 1/4] ab8500-charger: Check return value of regulator_enable Sachin Kamat
2013-09-06 8:01 ` [PATCH v3 2/4] ab8500-charger: Remove redundant break Sachin Kamat
2013-09-06 8:01 ` [PATCH v3 3/4] pm2301-charger: Check return value of regulator_enable Sachin Kamat
2013-09-06 9:37 ` Lee Jones
2013-09-06 8:01 ` [PATCH v3 4/4] pm2301-charger: Staticize pm2xxx_charger_die_therm_mngt Sachin Kamat
2013-09-06 9:38 ` [PATCH v3 1/4] ab8500-charger: Check return value of regulator_enable Lee Jones
2013-10-21 8:35 ` Sachin Kamat
2013-10-25 22:37 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131025223745.GA1157@teo \
--to=anton.vorontsov@linaro.org \
--cc=dwmw2@infradead.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.