All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <shijie8@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Marek Vasut <marex@denx.de>,
	dedekind1@gmail.com, tharvey@gateworks.com,
	stable@vger.kernel.org, Huang Shijie <b32955@freescale.com>,
	linux-mtd@lists.infradead.org, computersforpeace@gmail.com
Subject: Re: [PATCH V2] mtd: gpmi: fix the ecc regression
Date: Fri, 25 Oct 2013 21:41:17 -0400	[thread overview]
Message-ID: <20131026014115.GB3195@gmail.com> (raw)
In-Reply-To: <1382707782.8522.140.camel@shinybook.infradead.org>

On Fri, Oct 25, 2013 at 02:29:42PM +0100, David Woodhouse wrote:
> On Fri, 2013-10-25 at 21:33 -0400, Huang Shijie wrote:
> > 
> >   I am ok with your patch. but we will meet a compiler warning, since
> >   the set_geometry_by_ecc_info() is not referenced.
> 
> Yeah, I predicted that but at this stage with *hours* to catch Linux and
> get it into 3.12, I think that's the better option. I'll note it in the
> commit comment.

ok. Please add my ack for your formal patch:
Acked-by: Huang Shijie <shijie8@gmail.com>

  parent reply	other threads:[~2013-10-25 13:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-24  8:14 [PATCH V2] mtd: gpmi: fix the ecc regression Huang Shijie
2013-10-24  8:48 ` [PATCH v2 fix] " Huang Shijie
2013-10-24 22:19   ` Brian Norris
2013-10-25 13:36     ` David Woodhouse
2013-10-25 12:03 ` [PATCH V2] " David Woodhouse
2013-10-25 12:20   ` David Woodhouse
2013-10-25 13:22     ` Marek
2013-10-26  1:33     ` Huang Shijie
2013-10-25 13:29       ` David Woodhouse
2013-10-25 13:38         ` Marek
2013-10-26  1:41         ` Huang Shijie [this message]
2013-10-25 14:08           ` David Woodhouse
2013-10-25 17:08             ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131026014115.GB3195@gmail.com \
    --to=shijie8@gmail.com \
    --cc=b32955@freescale.com \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marex@denx.de \
    --cc=stable@vger.kernel.org \
    --cc=tharvey@gateworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.