All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: cw00.choi@samsung.com, myungjoo.ham@samsung.com,
	sameo@linux.intel.com, patches@opensource.wolfsonmicro.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] extcon: arizona: Fix reset of HPDET after race with removal
Date: Sat, 26 Oct 2013 18:27:35 +0100	[thread overview]
Message-ID: <20131026172735.GK20219@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20131026162907.GC7698@lee--X1>

On Sat, Oct 26, 2013 at 09:29:07AM -0700, Lee Jones wrote:
> What happens if we don't update the bits and we still do magic in the
> new error path? Does that adversely affect any later 'goto done's?

I think best leave this patch for now I should probably rethink
it slightly, as you say I am not sure all the paths through are
correct there.

I will post a new version shortly.

Thanks,
Charles

  reply	other threads:[~2013-10-26 17:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-26 14:10 [PATCH 1/2] extcon: arizona: Add defines for microphone detection levels Charles Keepax
2013-10-26 14:10 ` [PATCH 2/2] extcon: arizona: Fix reset of HPDET after race with removal Charles Keepax
2013-10-26 16:29   ` Lee Jones
2013-10-26 17:27     ` Charles Keepax [this message]
2013-10-26 16:23 ` [PATCH 1/2] extcon: arizona: Add defines for microphone detection levels Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131026172735.GK20219@opensource.wolfsonmicro.com \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=cw00.choi@samsung.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.