From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v3 3/4] drm/i915: remove device field from
 struct power_well
Date: Sun, 27 Oct 2013 20:30:24 +0100
Message-ID: <20131027193024.GL18189@phenom.ffwll.local>
References: <1382464076-5030-1-git-send-email-imre.deak@intel.com>
	<1382711810-25881-1-git-send-email-imre.deak@intel.com>
	<1382711810-25881-4-git-send-email-imre.deak@intel.com>
	<CA+gsUGQaAnAALPqR-sPzx9uA59K5a_NQTYQ+Aev78S17wUfJLQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51])
	by gabe.freedesktop.org (Postfix) with ESMTP id 05388E8FF4
	for <intel-gfx@lists.freedesktop.org>;
	Sun, 27 Oct 2013 12:29:57 -0700 (PDT)
Received: by mail-ee0-f51.google.com with SMTP id d41so2987997eek.38
	for <intel-gfx@lists.freedesktop.org>;
	Sun, 27 Oct 2013 12:29:57 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CA+gsUGQaAnAALPqR-sPzx9uA59K5a_NQTYQ+Aev78S17wUfJLQ@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Oct 25, 2013 at 05:50:18PM -0200, Paulo Zanoni wrote:
> 2013/10/25 Imre Deak <imre.deak@intel.com>:
> > The only real need for this field was in
> > i915_{request,release}_power_well, but there we can get at it by a
> > container_of magic. Also since in the future we'll have multiple power
> > wells each with its own power_well struct it makes sense to remove the
> > field from there where it'd be just redundancy.
> >
> > Suggested-by: Paulo Zanoni <paulo.zanoni@intel.com>
> 
> My original idea was to just move it from i915_power_well to
> i915_power_domains, so hsw_pwr (which is the new external static
> thing) would still have a pointer to our driver. This way we wouldn't
> need the container_of magic. But your solution works too, and saves
> 4/8 bytes :)
> 
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

First 3 patches merged, thanks.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch