From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] build: resolve build errors in dependent programs
Date: Sun, 27 Oct 2013 22:01:38 +0100 [thread overview]
Message-ID: <20131027210138.GA11945@localhost> (raw)
In-Reply-To: <1382279356-5050-3-git-send-email-jengelh@inai.de>
On Sun, Oct 20, 2013 at 04:29:16PM +0200, Jan Engelhardt wrote:
> The headers do not compile standalone, which also causes nftables to
> fail to build for the same reason. In addition, <stdbool.h> is not
> needed for C++, and C++ should use contemporary headers if available,
> which is hereby done.
>
> chain.h:44:71: warning: "struct nlmsghdr" declared inside
> parameter list [enabled by default]
> chain.h:60:35: error: unknown type name "size_t"
> expr.h:40:39: error: unknown type name "size_t"
> rule.h:43:64: warning: "struct nlmsghdr" declared inside
> parameter list [enabled by default]
> rule.h:59:34: error: unknown type name "size_t"
> ruleset.h:20:1: error: unknown type name "bool"
> ruleset.h:20:59: error: unknown type name "uint16_t"
> ruleset.h:39:37: error: unknown type name "size_t"
> set.h:38:33: error: unknown type name "size_t"
> table.h:32:71: warning: "struct nlmsghdr" declared inside
> parameter list [enabled by default]
> table.h:48:35: error: unknown type name "size_t"
This is fixing two different issues in one single patch.
I have applied a patch to add struct nlmsghdr without definition.
Regarding the c++ changes, we already discussed this in libmnl's
patch:
5b8a0c7 include: don't force compiler to enter C++11 mode
this change doesn't seem to be required by g++ at all.
next prev parent reply other threads:[~2013-10-27 21:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-20 14:29 libnftables: build fixes Jan Engelhardt
2013-10-20 14:29 ` [PATCH 1/2] build: resolve automake 1.12 warning Jan Engelhardt
2013-10-20 14:29 ` [PATCH 2/2] build: resolve build errors in dependent programs Jan Engelhardt
2013-10-27 21:01 ` Pablo Neira Ayuso [this message]
2013-10-28 12:27 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131027210138.GA11945@localhost \
--to=pablo@netfilter.org \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.