Re: [PATCH 2/3] charger-manager : Add default battery temperature checking funtion.

[Anton Vorontsov <anton@enomsg.org>]

On Mon, Oct 28, 2013 at 11:26:18AM +0900, jonghwa3.lee@samsung.com wrote:
> >> During the charger manager driver's probing time, it can't succeed
> >> if there's no pre-defined .temperature_out_of_range callback function.
> >> But if fuel gauge supports battery temperature measurement, we
> >> can use it directly. That's what cm_default_get_temp() function does.
> >>
> >> With flag measure_batter_temp ON, we normally use cm_default_get_temp()
> >> for .temperature_out_of_range callback funtion.
> >> The TEMP_AMBIENT property is only used for pre-defined one.
> >>
> >> Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
> >> Signed-off-by: Myungjoo Ham <myungjoo.ham@samsung.com>
> >> ---
> > ...
> >> +static int cm_default_get_temp(struct charger_manager *cm)
> >> +{
> >> +	struct charger_desc *desc = cm->desc;
> >> +	union power_supply_propval val;
> >> +	static int temp_alert_min = 0;
> >
> > No. Never.
> 
> Can I assume that you worried about initialization of a variable which would be
> used to hold minimum value to zero not INT_MAX or something big?

Nah, it's just any static variable inside a function is a big no-no. :)
With a very rare exceptions (mostly boot/arch code, which is not the case
here).

Basically, if you have to use static variables inside a function, it means
that you just broke device-driver separation.

Thanks,

Anton