From: Wei Liu <wei.liu2@citrix.com>
To: jerry <jerry.lilijun@huawei.com>
Cc: wei.liu2@citrix.com,
"qianhuibin@huawei.com" <qianhuibin@huawei.com>,
liuyongan@huawei.com, wangfuhai@huawei.com,
Jan Beulich <JBeulich@suse.com>,
qinchuanyu@huawei.com, xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: netback BUG_ON when using copy_skb=1
Date: Mon, 28 Oct 2013 11:43:29 +0000 [thread overview]
Message-ID: <20131028114329.GC23262@zion.uk.xensource.com> (raw)
In-Reply-To: <526B7E08.8050608@huawei.com>
On Sat, Oct 26, 2013 at 04:32:08PM +0800, jerry wrote:
[...]
>
> The patch is as follows:
> --- drivers/xen/netback/xenbus.c.old 2013-10-26 16:23:07.000000000 +0800
> +++ drivers/xen/netback/xenbus.c 2013-10-26 16:23:31.000000000 +0800
> @@ -156,9 +156,6 @@
> if (err)
> goto fail;
>
> - /* This kicks hotplug scripts, so do it immediately. */
> - backend_create_netif(be);
> -
> return 0;
>
> abort_transaction:
>
> Do you have some ideas?
>
My gut feeling is that this sort of change is regression-prone but we
have to live with that.
In any case, does upstream changeset ea732dff5c (xen-netback: Handle
backend state transitions in a more robust way) useful to you?
Wei.
next prev parent reply other threads:[~2013-10-28 11:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 4:13 netback BUG_ON when using copy_skb=1 jerry
2013-10-16 11:10 ` Jan Beulich
2013-10-17 7:41 ` jerry
2013-10-17 8:00 ` Jan Beulich
2013-10-17 10:26 ` jerry
2013-10-17 12:11 ` Jan Beulich
2013-10-22 1:18 ` jerry
2013-10-22 7:11 ` Jan Beulich
2013-10-26 8:32 ` jerry
2013-10-28 7:43 ` Jan Beulich
2013-10-29 4:04 ` jerry
2013-10-28 11:43 ` Wei Liu [this message]
2013-10-31 15:17 ` Ian Campbell
2013-10-31 15:32 ` Wei Liu
2013-11-01 2:53 ` jerry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131028114329.GC23262@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=jerry.lilijun@huawei.com \
--cc=liuyongan@huawei.com \
--cc=qianhuibin@huawei.com \
--cc=qinchuanyu@huawei.com \
--cc=wangfuhai@huawei.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.