From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@infradead.org>,
Alexander Gordeev <agordeev@redhat.com>,
Tejun Heo <tj@kernel.org>,
Nicholas Bellinger <nab@linux-iscsi.org>,
linux-kernel@vger.kernel.org
Subject: Re: blk-mq flush fix
Date: Mon, 28 Oct 2013 09:46:41 -0700 [thread overview]
Message-ID: <20131028164641.GA1046@infradead.org> (raw)
In-Reply-To: <526E90D7.1070604@kernel.dk>
On Mon, Oct 28, 2013 at 10:29:11AM -0600, Jens Axboe wrote:
> It's not that I think the existing patch is THAT bad, it fits in alright
> with the reserved tagging and works regardless of whether a driver uses
> reserved tags or not. And it does have the upside of not requiring
> special checks or logic for this special non-tagged request that using
> the preallocated would might need.
The problem with it is that it will pass a tag number to the low level
driver which it doesn't expect. In case the tags are used 1:1 as
hardware tags that would lead to nasy bugs.
At vefy least we'd need to mess with ->tag for this special request.
next prev parent reply other threads:[~2013-10-28 16:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-26 11:46 blk-mq flush fix Christoph Hellwig
2013-10-26 15:31 ` Christoph Hellwig
2013-10-27 22:29 ` Jens Axboe
2013-10-28 8:48 ` Christoph Hellwig
2013-10-28 16:29 ` Jens Axboe
2013-10-28 16:46 ` Christoph Hellwig [this message]
2013-10-28 16:59 ` Jens Axboe
2013-10-28 19:30 ` Christoph Hellwig
2013-10-28 19:39 ` Jens Axboe
[not found] ` <CANejiEWyznEOtRAXrsgEqGoo2EWJDGBt7XH4AZFksWSmR4UY+Q@mail.gmail.com>
2013-10-28 19:38 ` Jens Axboe
2013-10-28 19:47 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131028164641.GA1046@infradead.org \
--to=hch@infradead.org \
--cc=agordeev@redhat.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.