From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 4/4] drm/i915: WaFbcDisableDpfcClockGating
 only with fbc
Date: Mon, 28 Oct 2013 10:08:29 -0700
Message-ID: <20131028170829.GD3174@bwidawsk.net>
References: <1382633954-7375-1-git-send-email-benjamin.widawsky@intel.com>
	<1382633954-7375-4-git-send-email-benjamin.widawsky@intel.com>
	<CA+gsUGR5WHwCmT2UY8jR-X8m0gf-OEREA7+fOP6o2Wpw3E6DRw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112])
	by gabe.freedesktop.org (Postfix) with ESMTP id C7A6CE6EC7
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 28 Oct 2013 10:08:33 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CA+gsUGR5WHwCmT2UY8jR-X8m0gf-OEREA7+fOP6o2Wpw3E6DRw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>, Art Runyan <arthur.j.runyan@intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>, Ben Widawsky <benjamin.widawsky@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Oct 25, 2013 at 03:24:12PM -0200, Paulo Zanoni wrote:
> 2013/10/24 Ben Widawsky <benjamin.widawsky@intel.com>:
> > We were turning this on for SNB regardless of whether or not we use FBC.
> > We can save the slightest amount of power if we don't disable it when
> > not using FBC.
> >
> > The workaround should be bit 9 for SNB.
> 
> First, see comment in patch 3. So you're removing the WA on ILK and
> applying it for SNB-only. Since the spec doesn't say "SNB only", I
> guess we need this WA on both gens.

This is a question for Art, since he confirmed this privately IIRC.

Art does ILK need bit 8 and 9 set in 0x42020?

[snip]

-- 
Ben Widawsky, Intel Open Source Technology Center