From: Greg KH <gregkh@linuxfoundation.org>
To: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Cc: opw-kernel@googlegroups.com, linux-wireless@vger.kernel.org
Subject: Re: [OPW kernel] [Patch v3 1/3] net: wireless: replace printk with pr_warn in adm8211.c
Date: Mon, 28 Oct 2013 14:30:15 -0700 [thread overview]
Message-ID: <20131028213015.GA31597@kroah.com> (raw)
In-Reply-To: <20131026192053.GA10494@fireworks>
On Sat, Oct 26, 2013 at 10:20:53PM +0300, Georgiana Rodica Chelu wrote:
> WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(...
> to printk(KERN_WARNING ...
>
> Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
> ---
> drivers/net/wireless/adm8211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Like Sarah said, we can't take these as they are not against the staging
tree.
And even if they were:
> diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c
> index f9a24e5..e36d54d 100644
> --- a/drivers/net/wireless/adm8211.c
> +++ b/drivers/net/wireless/adm8211.c
> @@ -151,7 +151,7 @@ static int adm8211_read_eeprom(struct ieee80211_hw *dev)
> else
> priv->rf_type = ADM8211_TYPE_AIROHA;
>
> - printk(KERN_WARNING "%s (adm8211): Unknown RFtype %d\n",
> + pr_warn("%s (adm8211): Unknown RFtype %d\n",
You didn't read the message that sparse was telling you, why didn't you
convert this to netdev_warn() instead?
thanks,
greg k-h
prev parent reply other threads:[~2013-10-28 21:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-26 19:20 [Patch v3 1/3] net: wireless: replace printk with pr_warn in adm8211.c Georgiana Rodica Chelu
2013-10-28 21:30 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131028213015.GA31597@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=georgiana.chelu93@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=opw-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.