All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
Cc: vasily.isaenko@oracle.com, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: tests/generic: added -P option to df
Date: Tue, 29 Oct 2013 08:44:44 +1100	[thread overview]
Message-ID: <20131028214444.GE2797@dastard> (raw)
In-Reply-To: <1382444035-9502-1-git-send-email-stanislav.kholmanskikh@oracle.com>

On Tue, Oct 22, 2013 at 04:13:55PM +0400, Stanislav Kholmanskikh wrote:
> Otherwise the testcases will fail if the scratch
> device has a long name (for example, if it's an LVM volume).
> Because df outputs its usage stats with two lines:
> 
> /dev/mapper/xfstests-disk1
>                        3030800      4608   2868908   1% /tmp/mnt/disk1
> 
> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
> ---
>  tests/generic/251 |    2 +-
>  tests/generic/260 |    2 +-
>  tests/generic/273 |    2 +-
>  tests/generic/275 |    2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/generic/251 b/tests/generic/251
> index 4126f15..eca3b0d 100755
> --- a/tests/generic/251
> +++ b/tests/generic/251
> @@ -89,7 +89,7 @@ _guess_max_minlen()
>  fstrim_loop()
>  {
>  	trap "_destroy_fstrim; exit \$status" 2 15
> -	fsize=$(df | grep $SCRATCH_MNT | grep $SCRATCH_DEV  | awk '{print $2}')
> +	fsize=$(df -P | grep $SCRATCH_MNT | grep $SCRATCH_DEV  | awk '{print $2}')

Convert to $DF_PROG and add the -P flag to that variable, please.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2013-10-28 21:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-22 12:13 [PATCH] xfstests: tests/generic: added -P option to df Stanislav Kholmanskikh
2013-10-28  7:25 ` Stanislav Kholmanskikh
2013-10-28 21:44 ` Dave Chinner [this message]
2013-10-29  9:25   ` [PATCH V2] xfstests: added -P option to $DF_PROG Stanislav Kholmanskikh
2013-11-05 12:42     ` Stanislav Kholmanskikh
2013-11-10  1:20     ` Rich Johnston
2013-11-11 16:10     ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131028214444.GE2797@dastard \
    --to=david@fromorbit.com \
    --cc=stanislav.kholmanskikh@oracle.com \
    --cc=vasily.isaenko@oracle.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.