Re: [PATCH] ASoC: Add pinctrl PM to components of active DAIs

[Nicolin Chen <b42378@freescale.com>]

On Mon, Oct 28, 2013 at 09:44:05AM -0700, Mark Brown wrote:
> > +	for (i = 0; i < card->num_rtd; i++) {
> > +		struct snd_soc_pcm_runtime *rtd = &card->rtd[i];
> > +		struct snd_soc_dai *cpu_dai = rtd->cpu_dai;
> > +		pinctrl_pm_select_default_state(cpu_dai->dev);
> > +	}
> > +
> 
> This is going to put the pins into the default state during resume,
> that'll mean that if we're resuming a device which wasn't in use over
> suspend it'll be left in the default state after resume instead of in
> the idle state.
> 
> I'd expect the selection of the default state to be part of starting an
> audio stream and to only do something to active streams on suspend and
> resume.

You're right. I'll refine it soon.

Thank you,
Nicolin Chen