All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <b42378@freescale.com>
To: Timur Tabi <timur@tabi.org>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] ASoC: fsl_ssi: separately enable and disable TIE/RIE in trigger()
Date: Tue, 29 Oct 2013 19:57:11 +0800	[thread overview]
Message-ID: <20131029115711.GA9605@MrMyself> (raw)
In-Reply-To: <526FA330.3080209@tabi.org>

On Tue, Oct 29, 2013 at 06:59:44AM -0500, Timur Tabi wrote:
> Nicolin Chen wrote:
> >This patch enables Tx-related SIER_FLAGS only when direction is PLAYBACK
> >and does same thing for CAPTURE. Also, after TRIGGER_STOP/PAUSE, it will
> >disable SIER_xFLAGS for symmetric.
> 
> I'm okay with this patch in principle, but why bother?  The sysfs
> entry is going to display all interrupts anyway, and so the result
> will be the same.
>

Well, actually I just wanted to clear T/RDMAE to disable DMA request,
but it seems to be much easier to do it like this based on current
code and disabling unused interrupts should be better right? :)

Thank you,
Nicolin Chen

  reply	other threads:[~2013-10-29 12:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-29 11:04 [PATCH] ASoC: fsl_ssi: separately enable and disable TIE/RIE in trigger() Nicolin Chen
2013-10-29 11:04 ` Nicolin Chen
2013-10-29 11:59 ` Timur Tabi
2013-10-29 11:57   ` Nicolin Chen [this message]
2013-10-29 12:18     ` Timur Tabi
2013-10-29 12:13       ` Nicolin Chen
2013-10-29 12:40         ` Timur Tabi
2013-10-29 13:00           ` Chen Guangyu-B42378
2013-10-29 13:00             ` Chen Guangyu-B42378
2013-10-29 13:14             ` Timur Tabi
2013-10-29 13:16               ` Chen Guangyu-B42378
2013-10-29 13:16                 ` Chen Guangyu-B42378

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131029115711.GA9605@MrMyself \
    --to=b42378@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=timur@tabi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.