From: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
To: axboe@kernel.dk
Cc: stephenmcameron@gmail.com, akpm@linux-foundation.org,
mikem@beardog.cce.hp.com, linux-kernel@vger.kernel.org,
thenzl@redhat.com
Subject: [PATCH] cciss: return 0 from driver probe function on success, not 1
Date: Tue, 29 Oct 2013 13:41:35 -0500 [thread overview]
Message-ID: <20131029184135.5505.77412.stgit@beardog.cce.hp.com> (raw)
From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
A return value of 1 is interpreted as an error
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
---
drivers/block/cciss.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index edfa251..0c004ac 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -5183,7 +5183,7 @@ reinit_after_soft_reset:
rebuild_lun_table(h, 1, 0);
cciss_engage_scsi(h);
h->busy_initializing = 0;
- return 1;
+ return 0;
clean4:
cciss_free_cmd_pool(h);
next reply other threads:[~2013-10-29 18:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 18:41 Stephen M. Cameron [this message]
2013-10-29 18:58 ` [PATCH] cciss: return 0 from driver probe function on success, not 1 Jens Axboe
2013-10-31 21:42 ` Andrew Morton
2013-10-31 21:54 ` scameron
2013-10-31 22:06 ` Andrew Morton
2013-11-01 13:06 ` Tomas Henzl
2013-11-01 13:31 ` Andrew Morton
2013-11-01 14:08 ` scameron
2013-11-01 16:27 ` Tomas Henzl
-- strict thread matches above, loose matches on Subject: below --
2013-11-01 16:06 Stephen M. Cameron
2013-11-01 16:06 ` Stephen M. Cameron
2013-11-01 16:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029184135.5505.77412.stgit@beardog.cce.hp.com \
--to=scameron@beardog.cce.hp.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=mikem@beardog.cce.hp.com \
--cc=stephenmcameron@gmail.com \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.