From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbG5P-0006kM-DS for qemu-devel@nongnu.org; Tue, 29 Oct 2013 16:40:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbG5J-00038M-EG for qemu-devel@nongnu.org; Tue, 29 Oct 2013 16:40:23 -0400 Received: from nodalink.pck.nerim.net ([62.212.105.220]:37882 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbG5I-000387-TG for qemu-devel@nongnu.org; Tue, 29 Oct 2013 16:40:17 -0400 Date: Tue, 29 Oct 2013 21:40:05 +0100 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20131029204005.GF2948@irqsave.net> References: <1383035152-14924-1-git-send-email-namei.unix@gmail.com> <1383035152-14924-3-git-send-email-namei.unix@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1383035152-14924-3-git-send-email-namei.unix@gmail.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 2/2] sheepdog: support user-defined redundancy option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Yuan Cc: Kevin Wolf , sheepdog@lists.wpkg.org, qemu-devel@nongnu.org, Stefan Hajnoczi Le Tuesday 29 Oct 2013 =E0 16:25:52 (+0800), Liu Yuan a =E9crit : > Sheepdog support two kinds of redundancy, full replication and erasure = coding. >=20 > # create a fully replicated vdi with x copies > -o redundancy=3Dx (1 <=3D x <=3D SD_MAX_COPIES) >=20 > # create a erasure coded vdi with x data strips and y parity strips > -o redundancy=3Dx:y (x must be one of {2,4,8,16} and 1 <=3D y < SD_EC_= MAX_STRIP) >=20 > E.g, to convert a vdi into sheepdog vdi 'test' with 8:3 erasure coding = scheme >=20 > $ qemu-img convert -o redundancy=3D8:3 linux-0.2.img sheepdog:test >=20 > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > Signed-off-by: Liu Yuan > --- > block/sheepdog.c | 78 +++++++++++++++++++++++++++++++++++++= +++++++- > include/block/block_int.h | 1 + > 2 files changed, 78 insertions(+), 1 deletion(-) >=20 > diff --git a/block/sheepdog.c b/block/sheepdog.c > index e66d2f8..bd7cfd6 100644 > --- a/block/sheepdog.c > +++ b/block/sheepdog.c > @@ -91,6 +91,14 @@ > #define SD_NR_VDIS (1U << 24) > #define SD_DATA_OBJ_SIZE (UINT64_C(1) << 22) > #define SD_MAX_VDI_SIZE (SD_DATA_OBJ_SIZE * MAX_DATA_OBJS) > +/* > + * For erasure coding, we use at most SD_EC_MAX_STRIP for data strips = and > + * (SD_EC_MAX_STRIP - 1) for parity strips > + * > + * SD_MAX_COPIES is sum of number of dats trips and parity strips. > + */ > +#define SD_EC_MAX_STRIP 16 > +#define SD_MAX_COPIES (SD_EC_MAX_STRIP * 2 - 1) > =20 > #define SD_INODE_SIZE (sizeof(SheepdogInode)) > #define CURRENT_VDI_ID 0 > @@ -1446,6 +1454,65 @@ out: > return ret; > } > =20 > +static int64_t is_numeric(const char *s) > +{ > + char *end; > + return strtosz_suffix(s, &end, STRTOSZ_DEFSUFFIX_B); > +} > + > +/* > + * Sheepdog support two kinds of redundancy, full replication and eras= ure > + * coding. > + * > + * # create a fully replicated vdi with x copies > + * -o redundancy=3Dx (1 <=3D x <=3D SD_MAX_COPIES) > + * > + * # create a erasure coded vdi with x data strips and y parity strips > + * -o redundancy=3Dx:y (x must be one of {2,4,8,16} and 1 <=3D y < SD_= EC_MAX_STRIP) > + */ > +static int parse_redundancy(BDRVSheepdogState *s, const char *opt) > +{ > + struct SheepdogInode *inode =3D &s->inode; > + const char *n1, *n2; > + uint8_t copy, parity; > + char p[10]; > + > + strncpy(p, opt, sizeof(p)); > + n1 =3D strtok(p, ":"); > + n2 =3D strtok(NULL, ":"); > + > + if ((n1 && !is_numeric(n1)) || (n2 && !is_numeric(n2))) { > + return -EINVAL; > + } > + > + copy =3D strtol(n1, NULL, 10); > + if (copy > SD_MAX_COPIES) { > + return -EINVAL; > + } > + if (!n2) { > + inode->copy_policy =3D 0; > + inode->nr_copies =3D copy; > + } > + > + if (copy !=3D 2 && copy !=3D 4 && copy !=3D 8 && copy !=3D 16) { > + return -EINVAL; > + } > + > + parity =3D strtol(n2, NULL, 10); > + if (parity >=3D SD_EC_MAX_STRIP || parity =3D=3D 0) { > + return -EINVAL; > + } > + > + /* > + * 4 bits for parity and 4 bits for data. > + * We have to compress upper data bits because it can't represent = 16 > + */ > + inode->copy_policy =3D ((copy / 2) << 4) + parity; > + inode->nr_copies =3D copy + parity; > + > + return 0; > +} > + > static int sd_create(const char *filename, QEMUOptionParameter *option= s, > Error **errp) > { > @@ -1486,6 +1553,11 @@ static int sd_create(const char *filename, QEMUO= ptionParameter *options, > ret =3D -EINVAL; > goto out; > } > + } else if (!strcmp(options->name, BLOCK_OPT_REDUNDANCY)) { > + ret =3D parse_redundancy(s, options->value.s); > + if (ret < 0) { > + goto out; > + } > } > options++; > } > @@ -1528,7 +1600,6 @@ static int sd_create(const char *filename, QEMUOp= tionParameter *options, > bdrv_unref(bs); > } > =20 > - /* TODO: allow users to specify copy number */ > ret =3D do_sd_create(s, &vid, 0); > if (!prealloc || ret) { > goto out; > @@ -2332,6 +2403,11 @@ static QEMUOptionParameter sd_create_options[] =3D= { > .type =3D OPT_STRING, > .help =3D "Preallocation mode (allowed values: off, full)" > }, > + { > + .name =3D BLOCK_OPT_REDUNDANCY, > + .type =3D OPT_STRING, > + .help =3D "Redundancy of the image" > + }, > { NULL } > }; > =20 > diff --git a/include/block/block_int.h b/include/block/block_int.h > index a48731d..b90862f 100644 > --- a/include/block/block_int.h > +++ b/include/block/block_int.h > @@ -53,6 +53,7 @@ > #define BLOCK_OPT_COMPAT_LEVEL "compat" > #define BLOCK_OPT_LAZY_REFCOUNTS "lazy_refcounts" > #define BLOCK_OPT_ADAPTER_TYPE "adapter_type" > +#define BLOCK_OPT_REDUNDANCY "redundancy" > =20 > typedef struct BdrvTrackedRequest { > BlockDriverState *bs; > --=20 > 1.7.9.5 >=20 >=20 Hi, Perhaps it would be better to implement theses options with the new block= driver options mechanism that Kevin implemented. >>From a user perspective it look like this. -drive if=3Dvirtio,file.driver=3Dquorum,\ file.children.0.file.filename=3D1.qcow2,\ file.children.1.file.filename=3D2.qcow2,\ file.children.2.file.filename=3D3.qcow2,\ file.vote_threshold=3D3 I don't know if it would work with protocols but that would uniformize th= e options passing style accross multiple block drivers. I have an under review patch on the list using this mechanism, see: "[PATCH V9 11/11] quorum: Add quorum_open() and quorum_close()." Best regards Beno=EEt