From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [PATCH 17/23] dm: Refactor for new bio cloning/splitting Date: Tue, 29 Oct 2013 19:04:30 -0400 Message-ID: <20131029230430.GA2989@redhat.com> References: <1383077896-4132-1-git-send-email-kmo@daterainc.com> <1383077896-4132-18-git-send-email-kmo@daterainc.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1383077896-4132-18-git-send-email-kmo@daterainc.com> Sender: linux-kernel-owner@vger.kernel.org To: Kent Overstreet Cc: axboe@kernel.dk, dm-devel@redhat.com, linux-kernel@vger.kernel.org, hch@infradead.org, tj@kernel.org, Alasdair Kergon List-Id: dm-devel.ids On Tue, Oct 29 2013 at 4:18pm -0400, Kent Overstreet wrote: > We need to convert the dm code to the new bvec_iter primitives which > respect bi_bvec_done; they also allow us to drastically simplify dm's > bio splitting code. > > Also kill bio_sector_offset(), dm was the only user and it doesn't make > much sense anymore. > > Signed-off-by: Kent Overstreet > Cc: Jens Axboe > Cc: Alasdair Kergon > Cc: dm-devel@redhat.com I reviewed this patch some weeks ago (along with the rest of the DM changes), I provided the dm-thin.c changes in this patch: http://www.redhat.com/archives/dm-devel/2013-October/msg00027.html Please add: Signed-off-by: Mike Snitzer