From: Nicolin Chen <b42378@freescale.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: wm8962: Fix null pointer pdata access in I2C probe()
Date: Wed, 30 Oct 2013 09:31:51 +0800 [thread overview]
Message-ID: <20131030013150.GC9605@MrMyself> (raw)
In-Reply-To: <20131029163556.GI16686@sirena.org.uk>
On Tue, Oct 29, 2013 at 09:35:56AM -0700, Mark Brown wrote:
> > - for (i = 0; i < ARRAY_SIZE(pdata->gpio_init); i++)
> > - if (pdata->gpio_init[i]) {
> > + for (i = 0; i < ARRAY_SIZE(wm8962->pdata.gpio_init); i++)
> > + if (wm8962->pdata.gpio_init[i]) {
>
> ...it'd be neater to just ensure that pdata is always initialised.
I considered about that, and the patch could be neater. But then I
just found the code around this part are all using wm8962>pdata.*
pattern. So I stick the modification to it.
Thank you,
Nicolin Chen
prev parent reply other threads:[~2013-10-30 1:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 9:06 [PATCH] ASoC: wm8962: Fix null pointer pdata access in I2C probe() Nicolin Chen
2013-10-29 16:35 ` Mark Brown
2013-10-30 1:31 ` Nicolin Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030013150.GC9605@MrMyself \
--to=b42378@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.