From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-acpi@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Len Brown <lenb@kernel.org>,
Alex Williamson <alex.williamson@redhat.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI / hotplug / PCI: Always rescan the slot for new devices
Date: Wed, 30 Oct 2013 15:04:16 +0200 [thread overview]
Message-ID: <20131030130416.GF3521@intel.com> (raw)
In-Reply-To: <1406112.LRdFoqkugQ@vostro.rjw.lan>
On Wed, Oct 30, 2013 at 02:01:40PM +0100, Rafael J. Wysocki wrote:
> On Wednesday, October 30, 2013 02:40:36 PM Mika Westerberg wrote:
> > Commit 2dc4128 (ACPI / hotplug / PCI: Avoid doing too much for spurious
> > notifies) changed the enable_slot() to check return value of pci_scan_slot()
> > and if it is zero return early from the function. It means that there were
> > no new devices in this particular slot.
> >
> > However, if a device appeared deeper in the hierarchy the code now ignores
> > it causing things like Thunderbolt chaining fail to recognize new devices.
> >
> > The problem with Alex Williamson's machine was solved with commit
> > a47d8c8 (ACPI / hotplug / PCI: Avoid parent bus rescans on spurious device
> > checks) and hence we should be able to restore the original functionality
> > that we always rescan on bus check notification.
> >
> > On a device check notification we still check what acpiphp_rescan_slot()
> > returns and on zero bail out early.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> So, this is a revert of commit a47d8c8, correct?
Correct.
Plain revert didn't work because the code has changed after that commit.
next prev parent reply other threads:[~2013-10-30 13:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 12:40 [PATCH] ACPI / hotplug / PCI: Always rescan the slot for new devices Mika Westerberg
2013-10-30 13:01 ` Rafael J. Wysocki
2013-10-30 13:04 ` Mika Westerberg [this message]
2013-10-30 13:23 ` Rafael J. Wysocki
2013-10-30 13:57 ` Alex Williamson
2013-10-30 14:07 ` Mika Westerberg
2013-10-30 14:13 ` Rafael J. Wysocki
2013-10-30 14:24 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030130416.GF3521@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.