From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [PATCH]dm-mpath: fix for race condition between multipath_dtr and pg_init_done. Date: Wed, 30 Oct 2013 09:42:23 -0400 Message-ID: <20131030134223.GA7581@redhat.com> References: <20131017185306.GA29909@redhat.com> <52605B07.5070007@suse.de> <20131017211014.GA30993@redhat.com> <20131030005705.GA3569@redhat.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: "Merla, ShivaKrishna" Cc: "dm-devel@redhat.com" , Mikulas Patocka , "agk@redhat.com" List-Id: dm-devel.ids On Wed, Oct 30 2013 at 9:32am -0400, Merla, ShivaKrishna wrote: > > > > -----Original Message----- > > From: Mike Snitzer [mailto:snitzer@redhat.com] > > Sent: Tuesday, October 29, 2013 7:57 PM > > To: Merla, ShivaKrishna > > Cc: Hannes Reinecke; dm-devel@redhat.com; agk@redhat.com; Mikulas > > Patocka > > Subject: Re: [PATCH]dm-mpath: fix for race condition between > > multipath_dtr and pg_init_done. ... > > > > So... do you have an updated patch with proper locking that takes > > Hannes' patch into consideration? > > > > I'll be reviewing hannes patch closer (for v3.13) tomorrow so if you'd > > like your issue resolved in the near-term I'd appreciate us getting some > > closer on proposed solutions. > > > > Thanks, > > Mike > > I have re-submitted my patch with locking in multipath_dtr. I > revisited Hannes patch and I think we still have this issue when > multipath is destroyed and path activation work is queued. This is > with the scenario of scsi_dh_rdac returning SCSI_DH_RETRY on > mode_select due to 5/91/36 CC's. OK, I'll work toward including both patches.