From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [RFC PATCH v2] dm mpath: add a queue_if_no_path timeout Date: Wed, 30 Oct 2013 11:43:00 -0400 Message-ID: <20131030154259.GA8206@redhat.com> References: <20130926232241.GC31328@agk-dp.fab.redhat.com> <20130926234957.GA3658@redhat.com> <1382036590.1980.32.camel@bobble.lax.corp.google.com> <20131017191511.GA30452@redhat.com> <1382042759.1980.40.camel@bobble.lax.corp.google.com> <20131017211338.GB30993@redhat.com> <1382129515.1980.46.camel@bobble.lax.corp.google.com> <20131018225350.GB7553@redhat.com> <20131030010246.GA3611@redhat.com> <1383145687.6677.49.camel@bobble.lax.corp.google.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1383145687.6677.49.camel@bobble.lax.corp.google.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Frank Mayhar , hare@suse.de Cc: dm-devel , "Alasdair G. Kergon" List-Id: dm-devel.ids On Wed, Oct 30 2013 at 11:08am -0400, Frank Mayhar wrote: > On Tue, 2013-10-29 at 21:02 -0400, Mike Snitzer wrote: > > Any interest in this or should I just table it for >= v3.14? > > Sorry, I've been busy putting out another fire. Yes, there's definitely > still interest. I grabbed your revised patch and tested with it. > Unfortunately the timeout doesn't actually fire when requests are queued > due to queue_if_no_path; IIRC the block request queue timeout logic > wasn't triggering. I planned to look into it more deeply figure out why > but I had to spend all last week fixing a nasty race and hadn't gotten > back to it yet. OK, Hannes, any idea why this might be happening? The patch in question is here: https://patchwork.kernel.org/patch/3070391/