From: Greg KH <gregkh@linuxfoundation.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Tim Gardner <tim.gardner@canonical.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
the arch/x86 maintainers <x86@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Gleb Natapov <gleb@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
KVM list <kvm@vger.kernel.org>, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 3.12-rc7] KVM: Fix modprobe failure for kvm_intel/kvm_amd
Date: Wed, 30 Oct 2013 08:59:30 -0700 [thread overview]
Message-ID: <20131030155930.GA23433@kroah.com> (raw)
In-Reply-To: <527129D4.3010308@redhat.com>
On Wed, Oct 30, 2013 at 04:46:28PM +0100, Paolo Bonzini wrote:
> Il 30/10/2013 16:39, Raghavendra K T ha scritto:
> >>
> >> Why even error out at all here? You should never care about debugfs
> >> file creation return values, so why pass any error back up the stack?
> >
> > We could change this to return 0, but we will still be left with
> > kvm_main.c: kvm_init_debug() function which creates the kvm debugfs
> > directory. (I thought Paolo and Gleb's ack would be needed for
> > that change since it would be a bigger decision for me)
> >
> > So I just made the patch to fix only Linus's concern.
>
> Even if it is okay to exit and not create the files (and I think it's a
> bit surprising), I'd like at least a printk to signal what's happening.
> But there should be no reason for debugfs directory creation to fail in
> the end, except for basic mistakes such as the one that Tim reported, so
> I think it's better to report the failure.
Creation will "fail" if debugfs is not enabled, so spiting out printk
messages in that case is not a good idea.
greg k-h
next prev parent reply other threads:[~2013-10-30 15:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 15:13 [PATCH 3.12-rc7] KVM: Fix modprobe failure for kvm_intel/kvm_amd Tim Gardner
2013-10-29 16:45 ` Linus Torvalds
2013-10-29 19:27 ` Raghavendra K T
2013-10-29 19:33 ` Linus Torvalds
2013-10-30 14:01 ` Raghavendra K T
2013-10-30 14:23 ` Greg KH
2013-10-30 15:39 ` Raghavendra K T
2013-10-30 15:46 ` Paolo Bonzini
2013-10-30 15:59 ` Greg KH [this message]
2013-10-30 16:08 ` Paolo Bonzini
2013-10-30 16:23 ` Greg KH
2013-10-30 16:40 ` Paolo Bonzini
2013-10-29 20:00 ` Greg KH
2013-10-30 13:55 ` Raghavendra K T
2013-10-29 17:16 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030155930.GA23433@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=gleb@redhat.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tim.gardner@canonical.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.