From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 30 Oct 2013 18:47:01 -0200 From: Mauro Carvalho Chehab To: Aristeu Rozanski Cc: Bjorn Helgaas , Borislav Petkov , linux-edac@vger.kernel.org, Tony Luck , Doug Thompson , open list , "open list:PCI SUBSYSTEM" Subject: Re: [PATCH 01/12] sb_edac: move PCI IDs to pci_ids.h Message-id: <20131030184701.5a4f97b1@samsung.com> In-reply-to: <20131030203516.GE16166@redhat.com> References: <1383150426-24730-1-git-send-email-arozansk@redhat.com> <1383150426-24730-2-git-send-email-arozansk@redhat.com> <20131030164020.GF13290@pd.tnic> <20131030151936.48ba7af5@samsung.com> <20131030203516.GE16166@redhat.com> MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: Em Wed, 30 Oct 2013 16:35:17 -0400 Aristeu Rozanski escreveu: > On Wed, Oct 30, 2013 at 11:21:49AM -0600, Bjorn Helgaas wrote: > > On Wed, Oct 30, 2013 at 11:19 AM, Mauro Carvalho Chehab > > wrote: > > > Em Wed, 30 Oct 2013 17:40:20 +0100 > > > Borislav Petkov escreveu: > > > > > >> On Wed, Oct 30, 2013 at 12:26:55PM -0400, Aristeu Rozanski wrote: > > >> > According to the comment, it should be done before submitting upstream. > > >> > > > >> > Signed-off-by: Aristeu Rozanski > > >> > --- > > >> > drivers/edac/sb_edac.c | 21 ++------------------- > > >> > include/linux/pci_ids.h | 11 +++++++++++ > > >> > 2 files changed, 13 insertions(+), 19 deletions(-) > > >> > > > >> > diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c > > >> > index e04462b..4cdd948 100644 > > >> > --- a/drivers/edac/sb_edac.c > > >> > +++ b/drivers/edac/sb_edac.c > > >> > @@ -57,26 +57,9 @@ static int probed; > > >> > */ > > >> > > > >> > /* > > >> > - * FIXME: For now, let's order by device function, as it makes > > >> > - * easier for driver's development process. This table should be > > >> > - * moved to pci_id.h when submitted upstream > > >> > > >> Why, is anything else besides sb_edac.c using those? > > >> > > > I think that this patch makes sense, as the other Sandy Bridge registers > > > are at pci_ids.h. So, it is a matter of consistency. > > > > > > Also, I won't doubt that other drivers could need to access those, as > > > there are other things there on a few of those PCI IDs. > > > > > > Yet, on patch 12/12, you're adding the Ivy Bridge specific PCI IDs > > > inside the driver. > > > > > > So, IMHO, you should either move all to pci_ids.h or to keep them inside > > > the driver. > > > > > > My personal taste would be to move them all to pci_ids.h. > > > > As long as it follows the guideline at the top of pci_ids.h (add them > > there only if they are shared between multiple drivers), I'm fine with > > putting them in pci_ids.h. > > Fair enough, I think we can drop the first patch. I checked and all the > patches apply without the first one and it builds fine. Mauro, want me > to resubmit the patchset anyway? No need. Thanks! Mauro