From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Tejun Heo <tj@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: WTF: driver-core-next contains recursive directory removal!
Date: Wed, 30 Oct 2013 15:44:44 -0700 [thread overview]
Message-ID: <20131030224444.GA9092@kroah.com> (raw)
In-Reply-To: <8761sexu2l.fsf@xmission.com>
On Wed, Oct 30, 2013 at 03:38:58PM -0700, Eric W. Biederman wrote:
>
> Greg what is going on? I just looked and Tejuns ill-conceived recursive
> directory deletion code has been merged into your driver-core-next tree.
>
> That code is semantically broken. I reviewed it and I gave the reasons
> why it was wrong. You came up to me and mentioned at LPC that you
> agreed with my reasons. And yet I just looked in driver-core-next and
> there the code is in all of it's broken glory.
Because I tested it out, and there were no such problems.
> Please pull out that crap it has no business ever going into a stable
> kernel.
Really? It seems to survive my testing here just fine.
> The short version is unless someone has drastically changed pci hotplug
> since last time I looked the code is dramatically wrong as pci hotplug
> removes directories in the wrong order remove the parent first.
That should still work here, and I'm pretty sure I tested it, but will
do so before I send it to Linus.
I don't think there's an issue here, otherwise both Tejun and I would
have found some issues during testing, same for all of the other
linux-next users for the past few weeks.
thanks,
greg k-h
next prev parent reply other threads:[~2013-10-30 22:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 22:38 WTF: driver-core-next contains recursive directory removal! Eric W. Biederman
2013-10-30 22:44 ` Greg Kroah-Hartman [this message]
2013-10-30 22:57 ` Eric W. Biederman
2013-10-31 15:24 ` Tejun Heo
2013-10-31 1:19 ` Eric W. Biederman
2013-10-31 15:29 ` Tejun Heo
2013-10-31 13:17 ` Bjorn Helgaas
2013-10-31 15:02 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030224444.GA9092@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.