diff for duplicates of <20131031074436.GG9605@MrMyself> diff --git a/a/1.txt b/N1/1.txt index 9e0d8d0..6c4f156 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,29 +1,29 @@ Hi, Philippe -On Thu, Oct 31, 2013 at 08:54:12AM +0100, Philippe Rétornaz wrote: +On Thu, Oct 31, 2013 at 08:54:12AM +0100, Philippe R=E9tornaz wrote: > Hi -> +>=20 > > > >+ /* When using dual fifo mode, we need to keep watermark > >+ * as even numbers due to dma script limitation. > >+ */ -> >+ ssi_private->dma_params_tx.maxburst /= 2; -> >+ ssi_private->dma_params_tx.maxburst *= 2; -> >+ ssi_private->dma_params_rx.maxburst /= 2; -> >+ ssi_private->dma_params_rx.maxburst *= 2; +> >+ ssi_private->dma_params_tx.maxburst /=3D 2; +> >+ ssi_private->dma_params_tx.maxburst *=3D 2; +> >+ ssi_private->dma_params_rx.maxburst /=3D 2; +> >+ ssi_private->dma_params_rx.maxburst *=3D 2; > > -> +>=20 > Why not using a mask here ? -> ssi_private->dma_params_tx.maxburst &= ~0x1; -> ssi_private->dma_params_rx.maxburst &= ~0x1; +> ssi_private->dma_params_tx.maxburst &=3D ~0x1; +> ssi_private->dma_params_rx.maxburst &=3D ~0x1; I'll use this in v3. Thank you! Nicolin Chen -> +>=20 > Regards, -> +>=20 > Philippe -> -> +>=20 +>=20 diff --git a/a/content_digest b/N1/content_digest index ed0c17b..b14b100 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,53 +5,53 @@ "Subject\0Re: [PATCH v2 3/4] ASoC: fsl_ssi: Add dual fifo mode support\0" "Date\0Thu, 31 Oct 2013 15:44:37 +0800\0" "To\0Philippe R\303\251tornaz <philippe.retornaz@gmail.com>\0" - "Cc\0s.hauer@pengutronix.de" - timur@tabi.org - shawn.guo@linaro.org - broonie@kernel.org - mark.rutland@arm.com + "Cc\0mark.rutland@arm.com" devicetree@vger.kernel.org alsa-devel@alsa-project.org pawel.moll@arm.com linux-doc@vger.kernel.org + s.hauer@pengutronix.de swarren@wwwdotorg.org - linux-kernel@vger.kernel.org + timur@tabi.org rob.herring@calxeda.com + linux-kernel@vger.kernel.org + broonie@kernel.org galak@codeaurora.org dmaengine@vger.kernel.org ijc+devicetree@hellion.org.uk + shawn.guo@linaro.org linuxppc-dev@lists.ozlabs.org " linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Hi, Philippe\n" "\n" - "On Thu, Oct 31, 2013 at 08:54:12AM +0100, Philippe R\303\251tornaz wrote:\n" + "On Thu, Oct 31, 2013 at 08:54:12AM +0100, Philippe R=E9tornaz wrote:\n" "> Hi\n" - "> \n" + ">=20\n" "> >\n" "> >+\t\t\t/* When using dual fifo mode, we need to keep watermark\n" "> >+\t\t\t * as even numbers due to dma script limitation.\n" "> >+\t\t\t */\n" - "> >+\t\t\tssi_private->dma_params_tx.maxburst /= 2;\n" - "> >+\t\t\tssi_private->dma_params_tx.maxburst *= 2;\n" - "> >+\t\t\tssi_private->dma_params_rx.maxburst /= 2;\n" - "> >+\t\t\tssi_private->dma_params_rx.maxburst *= 2;\n" + "> >+\t\t\tssi_private->dma_params_tx.maxburst /=3D 2;\n" + "> >+\t\t\tssi_private->dma_params_tx.maxburst *=3D 2;\n" + "> >+\t\t\tssi_private->dma_params_rx.maxburst /=3D 2;\n" + "> >+\t\t\tssi_private->dma_params_rx.maxburst *=3D 2;\n" "> >\n" - "> \n" + ">=20\n" "> Why not using a mask here ?\n" - "> ssi_private->dma_params_tx.maxburst &= ~0x1;\n" - "> ssi_private->dma_params_rx.maxburst &= ~0x1;\n" + "> ssi_private->dma_params_tx.maxburst &=3D ~0x1;\n" + "> ssi_private->dma_params_rx.maxburst &=3D ~0x1;\n" "\n" "I'll use this in v3. Thank you!\n" "\n" "Nicolin Chen\n" "\n" - "> \n" + ">=20\n" "> Regards,\n" - "> \n" + ">=20\n" "> Philippe\n" - "> \n" - > + ">=20\n" + >=20 -1780cd8980fe60b655de10973dcf9e32d13b37592e1f9dd5b7b43c3643c0e7fd +750ad5594049f433b87f8eea2ad1c6aab893db12d007f762d7808df593c95c60
diff --git a/a/1.txt b/N2/1.txt index 9e0d8d0..c387982 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,6 +1,6 @@ Hi, Philippe -On Thu, Oct 31, 2013 at 08:54:12AM +0100, Philippe Rétornaz wrote: +On Thu, Oct 31, 2013 at 08:54:12AM +0100, Philippe R?tornaz wrote: > Hi > > > diff --git a/a/content_digest b/N2/content_digest index ed0c17b..9a83b06 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,32 +1,15 @@ "ref\0cover.1383197521.git.b42378@freescale.com\0" "ref\00e947536358af7bd6e179559006a3526801a1abe.1383197521.git.b42378@freescale.com\0" "ref\052720CA4.3090003@gmail.com\0" - "From\0Nicolin Chen <b42378@freescale.com>\0" - "Subject\0Re: [PATCH v2 3/4] ASoC: fsl_ssi: Add dual fifo mode support\0" + "From\0b42378@freescale.com (Nicolin Chen)\0" + "Subject\0[PATCH v2 3/4] ASoC: fsl_ssi: Add dual fifo mode support\0" "Date\0Thu, 31 Oct 2013 15:44:37 +0800\0" - "To\0Philippe R\303\251tornaz <philippe.retornaz@gmail.com>\0" - "Cc\0s.hauer@pengutronix.de" - timur@tabi.org - shawn.guo@linaro.org - broonie@kernel.org - mark.rutland@arm.com - devicetree@vger.kernel.org - alsa-devel@alsa-project.org - pawel.moll@arm.com - linux-doc@vger.kernel.org - swarren@wwwdotorg.org - linux-kernel@vger.kernel.org - rob.herring@calxeda.com - galak@codeaurora.org - dmaengine@vger.kernel.org - ijc+devicetree@hellion.org.uk - linuxppc-dev@lists.ozlabs.org - " linux-arm-kernel@lists.infradead.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Hi, Philippe\n" "\n" - "On Thu, Oct 31, 2013 at 08:54:12AM +0100, Philippe R\303\251tornaz wrote:\n" + "On Thu, Oct 31, 2013 at 08:54:12AM +0100, Philippe R?tornaz wrote:\n" "> Hi\n" "> \n" "> >\n" @@ -54,4 +37,4 @@ "> \n" > -1780cd8980fe60b655de10973dcf9e32d13b37592e1f9dd5b7b43c3643c0e7fd +485796eededefdee9078ebae703331c0aa2d0135e0f803f4d7cbd6b2ca7e3dfd
diff --git a/a/content_digest b/N3/content_digest index ed0c17b..06f6e02 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -5,23 +5,23 @@ "Subject\0Re: [PATCH v2 3/4] ASoC: fsl_ssi: Add dual fifo mode support\0" "Date\0Thu, 31 Oct 2013 15:44:37 +0800\0" "To\0Philippe R\303\251tornaz <philippe.retornaz@gmail.com>\0" - "Cc\0s.hauer@pengutronix.de" - timur@tabi.org - shawn.guo@linaro.org - broonie@kernel.org - mark.rutland@arm.com - devicetree@vger.kernel.org - alsa-devel@alsa-project.org - pawel.moll@arm.com - linux-doc@vger.kernel.org - swarren@wwwdotorg.org - linux-kernel@vger.kernel.org - rob.herring@calxeda.com - galak@codeaurora.org - dmaengine@vger.kernel.org - ijc+devicetree@hellion.org.uk - linuxppc-dev@lists.ozlabs.org - " linux-arm-kernel@lists.infradead.org\0" + "Cc\0<s.hauer@pengutronix.de>" + <timur@tabi.org> + <shawn.guo@linaro.org> + <broonie@kernel.org> + <mark.rutland@arm.com> + <devicetree@vger.kernel.org> + <alsa-devel@alsa-project.org> + <pawel.moll@arm.com> + <linux-doc@vger.kernel.org> + <swarren@wwwdotorg.org> + <linux-kernel@vger.kernel.org> + <rob.herring@calxeda.com> + <galak@codeaurora.org> + <dmaengine@vger.kernel.org> + <ijc+devicetree@hellion.org.uk> + <linuxppc-dev@lists.ozlabs.org> + " <linux-arm-kernel@lists.infradead.org>\0" "\00:1\0" "b\0" "Hi, Philippe\n" @@ -54,4 +54,4 @@ "> \n" > -1780cd8980fe60b655de10973dcf9e32d13b37592e1f9dd5b7b43c3643c0e7fd +0666b520c4b3a9bb23970fe35dd91a5df71ac04599f0fadb44b964ad4d762de4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.