From: Marek Vasut <marex@denx.de>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: m25p80: fixup device removal failure path
Date: Thu, 31 Oct 2013 08:36:36 +0100 [thread overview]
Message-ID: <201310310836.36976.marex@denx.de> (raw)
In-Reply-To: <1383176571-28057-1-git-send-email-computersforpeace@gmail.com>
Dear Brian Norris,
> Device removal shouls fail if MTD unregistration fails.
should ;-)
Reviewed-by: Marek Vasut <marex@denx.de>
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> ---
> drivers/mtd/devices/m25p80.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index 58978892c321..7eda71dbc183 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -1125,9 +1125,7 @@ static int m25p_remove(struct spi_device *spi)
> struct m25p *flash = spi_get_drvdata(spi);
>
> /* Clean up MTD stuff. */
> - mtd_device_unregister(&flash->mtd);
> -
> - return 0;
> + return mtd_device_unregister(&flash->mtd);
> }
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-10-31 7:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 23:42 [PATCH] mtd: m25p80: fixup device removal failure path Brian Norris
2013-10-31 7:36 ` Marek Vasut [this message]
2013-10-31 14:27 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201310310836.36976.marex@denx.de \
--to=marex@denx.de \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.