From: Joe MacDonald <joe@deserted.net>
To: Martin Jansa <martin.jansa@gmail.com>,
Zongchun YU <b40527@freescale.com>,
'Zongchun Yu' <Zongchun.Yu@freescale.com>
Cc: openembedded-devel@lists.openembedded.org, b44149@freescale.com
Subject: Re: [meta-oe][PATCH v2] tcpreplay:add recipe
Date: Thu, 31 Oct 2013 09:56:33 -0400 [thread overview]
Message-ID: <20131031135632.GA4563@deserted.net> (raw)
In-Reply-To: <20131031092314.GF32015@jama>
[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]
[Re: [oe] [meta-oe][PATCH v2] tcpreplay:add recipe] On 13.10.31 (Thu 10:23) Martin Jansa wrote:
> On Thu, Oct 31, 2013 at 05:09:07PM +0800, Zongchun YU wrote:
> > Hi Martin.
> >
> > Thanks for your kind comments. I see tcpdump in meta-oe layer too. tcpreplay
> > may use packages captured by tcpdump.
> > putting them in the same layer maybe better. Wish your suggestion?
> >
> > Best Regards
> > Zongchun
>
> +Joe
>
> tcpdump is used only in one meta-oe recipe, were it can be dropped or
> replaced with PACKAGECONFIG
>
> meta-oe/recipes-core/packagegroups/packagegroup-cli-tools.bb: tcpdump
>
> And then we can move tcpdump to meta-networking and add tcpreplay there.
Wow, been a while since I thought about tcpdump's location in the tree.
I knew we'd discussed moving it to meta-networking it previously and it
didn't move but I couldn't remember why. Looks like it was mostly due
to inertia. I've no objection to relocating it, I think it's a sensible
location for it anyway. Zongchun: would you be able to prepare a patch
set that includes the move and the introduction of tcpreplay?
As for the recipe itself, I only noticed two small things on a quick
scan. tcpreplay-3.4.4-no-bfp-support.patch is lacking OE headers, at
least an upstream-status is important here, even though it's pretty
clear what that'll be. :-) Also, I don't think you need the PR in the
recipe.
--
-Joe MacDonald.
:wq
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2013-10-31 13:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 7:40 [meta-oe][PATCH v2] tcpreplay:add recipe b40527
2013-10-31 8:10 ` Martin Jansa
2013-10-31 9:09 ` Zongchun YU
2013-10-31 9:23 ` Martin Jansa
2013-10-31 13:56 ` Joe MacDonald [this message]
2013-11-01 3:22 ` Zongchun YU
2013-11-01 11:08 ` Martin Jansa
2013-11-01 11:35 ` Zongchun YU
2013-10-31 16:35 ` Khem Raj
2013-11-01 3:05 ` Zongchun YU
2013-11-01 4:55 ` [meta-oe][PATCH] " Khem Raj
2013-11-01 10:57 ` [meta-oe][PATCH v2] " w201cruiser .
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031135632.GA4563@deserted.net \
--to=joe@deserted.net \
--cc=Zongchun.Yu@freescale.com \
--cc=b40527@freescale.com \
--cc=b44149@freescale.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.