Re: [PATCH 1/1] dmaengine: s3c24xx-dma: use DMA_COMPLETE for dma completion status

["Heiko Stübner" <heiko@sntech.de>]

Am Donnerstag, 31. Oktober 2013, 06:18:09 schrieb Sachin Kamat:
> Use the recently introduced DMA_COMPLETE instead of DMA_SUCCESS.
> Without this patch we get the following build error:
> drivers/dma/s3c24xx-dma.c: In function ‘s3c24xx_dma_tx_status’:
> drivers/dma/s3c24xx-dma.c:798:13: error: ‘DMA_SUCCESS’ undeclared
> (first use in this function)
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

thanks for the catch!

Acked-by: Heiko Stuebner <heiko@sntech.de>


> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Vinod Koul <vinod.koul@intel.com>
> ---
>  drivers/dma/s3c24xx-dma.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/s3c24xx-dma.c b/drivers/dma/s3c24xx-dma.c
> index 4cb127978636..085da4fe6613 100644
> --- a/drivers/dma/s3c24xx-dma.c
> +++ b/drivers/dma/s3c24xx-dma.c
> @@ -795,7 +795,7 @@ static enum dma_status s3c24xx_dma_tx_status(struct
> dma_chan *chan,
> 
>  	spin_lock_irqsave(&s3cchan->vc.lock, flags);
>  	ret = dma_cookie_status(chan, cookie, txstate);
> -	if (ret == DMA_SUCCESS) {
> +	if (ret == DMA_COMPLETE) {
>  		spin_unlock_irqrestore(&s3cchan->vc.lock, flags);
>  		return ret;
>  	}