All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamie Iles <jamie.iles@oracle.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jamie Iles <jamie.iles@oracle.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] recordmcount.pl: add support for __fentry__
Date: Thu, 31 Oct 2013 16:18:26 +0000	[thread overview]
Message-ID: <20131031161826.GH29371@localhost> (raw)
In-Reply-To: <20131031120926.112c3c26@gandalf.local.home>

On Thu, Oct 31, 2013 at 12:09:26PM -0400, Steven Rostedt wrote:
> On Thu, 31 Oct 2013 15:59:58 +0000
> Jamie Iles <jamie.iles@oracle.com> wrote:
> 
> > With gcc 4.6.0 the -mfentry feature places the function profiling call
> > at the start of the function. When this is used, the call is to
> > __fentry__ and not mcount.
> > 
> > Based on 48bb5dc6cd9d30fe0d594947563da1f8bd9abada (ftrace: Make
> > recordmcount.c handle __fentry__).
> 
> Why? All current users of __fentry__ use the C version of recordmcount.
> This just slows down the few archs that still use recordmcount.pl.

Okay, it's probably fair to drop this one then if it's not useful to the 
other arches.  We have a corner case with Ksplice where the C version of 
mcount not writing the section symbol for __mcount_loc causes a problem 
and we fall back to the perl version, but I'll spend some time working 
on fixing that instead.

Thanks,

Jamie

      reply	other threads:[~2013-10-31 16:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-31 15:59 [PATCH] recordmcount.pl: add support for __fentry__ Jamie Iles
2013-10-31 16:09 ` Steven Rostedt
2013-10-31 16:18   ` Jamie Iles [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131031161826.GH29371@localhost \
    --to=jamie.iles@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.