From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleg Nesterov Subject: Re: [PATCH 3/4][v2] audit: move audit_aux_data_execve contents into audit_context union Date: Thu, 31 Oct 2013 18:18:10 +0100 Message-ID: <20131031171810.GA8757@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Richard Guy Briggs Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org, "Eric W. Biederman" , Eric Paris List-Id: linux-audit@redhat.com On 10/31, Richard Guy Briggs wrote: > > --- a/kernel/audit.h > +++ b/kernel/audit.h > @@ -197,6 +197,10 @@ struct audit_context { > int fd; > int flags; > } mmap; > + struct { > + int argc; > + struct mm_struct *mm; > + } execve; Ah, nice, so we should not worry about kmalloc(GFP_KERNEL) failure. I am in no position to ack the changes in this area, but the whole series looks fine to me. Oleg.