From: Minchan Kim <minchan@kernel.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: opw-kernel@googlegroups.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiang Liu <jiang.liu@huawei.com>, Nitin Gupta <ngupta@vflare.org>,
Jerome Marchand <jmarchand@redhat.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v9 2/2] Staging: zram: Fix decrement of variable by calling bdput()
Date: Fri, 1 Nov 2013 11:00:04 +0900 [thread overview]
Message-ID: <20131101020004.GH26080@bbox> (raw)
In-Reply-To: <4fdb273ab0b1e7514f119d7e619ac708d2277d34.1383220461.git.rashika.kheria@gmail.com>
I hope subject should be "Fix memory leak by refcount mismatch"
On Thu, Oct 31, 2013 at 05:28:18PM +0530, Rashika Kheria wrote:
> As suggested by Jerome Marchand "The code in reset_store get the block device
> (bdget_disk()) but it does not put it (bdput()) when it's done using it.
> The usage count is therefore incremented but never decremented."
>
> This patch also puts bdput() for all error cases.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Other than that,
Acked-by: Minchan Kim <minchan@kernel.org>
Rashika, Thanks!
--
Kind regards,
Minchan Kim
next prev parent reply other threads:[~2013-11-01 1:59 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20131019110539.GA25167@gmail.com>
2013-10-28 11:47 ` [PATCH v5 1/3] Staging: zram: Fix access of NULL pointer Rashika Kheria
2013-10-28 11:48 ` [PATCH v5 3/3] Staging: zram: Fix decrement of variable by calling bdput() Rashika Kheria
2013-10-28 12:17 ` [PATCH v5 2/3] Staging: zram: Fix variable dereferenced before check Rashika Kheria
2013-10-28 12:21 ` [PATCH v6 1/3] Staging: zram: Fix access of NULL pointer Rashika Kheria
2013-10-28 12:23 ` [PATCH v6 2/3] Staging: zram: Fix variable dereferenced before check Rashika Kheria
2013-10-29 0:44 ` Minchan Kim
2013-10-28 12:24 ` [PATCH v6 3/3] Staging: zram: Fix decrement of variable by calling bdput() Rashika Kheria
2013-10-29 0:47 ` Minchan Kim
2013-10-28 13:45 ` [PATCH v6 1/3] Staging: zram: Fix access of NULL pointer Weijie Yang
[not found] ` <CAMpEsFHO5yrwxK9q=hQtOxwC=0_p4BznBGjvomPgFZogwXABRA@mail.gmail.com>
2013-10-28 15:09 ` Weijie Yang
2013-10-29 0:43 ` Minchan Kim
2013-10-29 23:10 ` [PATCH v7 " Rashika Kheria
2013-10-29 23:12 ` [PATCH v7 2/3] Staging: zram: Fix decrement of variable by calling bdput() Rashika Kheria
2013-10-30 2:33 ` Minchan Kim
2013-10-29 23:15 ` [PATCH v7 3/3] Staging: zram: Fix variable dereferenced before check Rashika Kheria
2013-10-30 2:35 ` Minchan Kim
2013-10-30 10:44 ` Jerome Marchand
2013-10-30 2:24 ` [PATCH v7 1/3] Staging: zram: Fix access of NULL pointer Minchan Kim
2013-10-30 2:36 ` Minchan Kim
2013-10-30 10:42 ` Jerome Marchand
2013-10-30 13:06 ` [PATCH v8 " Rashika Kheria
2013-10-30 13:10 ` [PATCH v8 2/3] Staging: zram: Fix decrement of variable by calling bdput() Rashika Kheria
2013-10-31 9:42 ` Weijie Yang
2013-10-30 13:13 ` [PATCH v8 3/3] Staging: zram: Fix variable dereferenced before check Rashika Kheria
2013-10-30 16:36 ` Greg Kroah-Hartman
2013-10-31 11:56 ` [PATCH v9 1/2] Staging: zram: Fix access of NULL pointer Rashika Kheria
2013-10-31 11:58 ` [PATCH v9 2/2] Staging: zram: Fix decrement of variable by calling bdput() Rashika Kheria
2013-11-01 2:00 ` Minchan Kim [this message]
2013-11-01 8:54 ` Jerome Marchand
2013-11-01 14:13 ` Rashika Kheria
2013-11-01 14:06 ` [PATCH v10] Staging: zram: Fix memory leak by refcount mismatch Rashika Kheria
2013-11-10 15:45 ` Greg Kroah-Hartman
2013-11-10 15:56 ` [OPW kernel] " Rashika Kheria
2013-11-10 16:10 ` Greg Kroah-Hartman
2013-11-10 16:14 ` Rashika Kheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131101020004.GH26080@bbox \
--to=minchan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jiang.liu@huawei.com \
--cc=jmarchand@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=opw-kernel@googlegroups.com \
--cc=rashika.kheria@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.