From: Ingo Molnar <mingo@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
LKML <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>
Subject: Re: perf version not set when building out of tree
Date: Fri, 1 Nov 2013 08:02:19 +0100 [thread overview]
Message-ID: <20131101070219.GA21471@gmail.com> (raw)
In-Reply-To: <5272E86B.7090003@gmail.com>
* David Ahern <dsahern@gmail.com> wrote:
> When building out of tree:
>
> make perf-tar-src-pkg
What's the canonical way to build a perf tarball? I didn't find any
makefile target for that.
> tar -xf perf-<ver>.tar -C /tmp
> cd /tmp/perf<ver>
> make -C tools/perf
>
> you get the warning message:
> make[1]: *** No rule to make target `kernelversion'. Stop.
>
> which comes from tools/perf/util/PERF-VERSION-GEN,
>
> if test -z "$TAG"
> then
> TAG=$(MAKEFLAGS= make -sC ../.. kernelversion)
> fi
>
> There is no top level Makefile. perf is actually built, but has no
> version info:
>
> $ tools/perf/perf --version
> perf version
>
> I thought someone had proposed a way to fix that.
I think we should pack the PERF-VERSION-FILE with the tarball and
use that. This needs roughly 3 changes:
- make PERF-VERSION-FILE part of the tarball
- make sure it's not zapped on 'make clean'
- don't try to regenerate it if there's no git repository to get a version from
Thanks,
Ingo
next prev parent reply other threads:[~2013-11-01 7:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 23:31 perf version not set when building out of tree David Ahern
2013-11-01 7:02 ` Ingo Molnar [this message]
2013-11-01 13:30 ` David Ahern
2013-11-01 15:41 ` Ingo Molnar
2013-11-05 23:58 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131101070219.GA21471@gmail.com \
--to=mingo@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.