From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Select CONFIG_AGP and
 CONFIG_AGP_INTEL
Date: Fri, 1 Nov 2013 11:00:01 +0200
Message-ID: <20131101090001.GF13047@intel.com>
References: <1383295128-23857-1-git-send-email-ville.syrjala@linux.intel.com>
	<CAKMK7uHYpRsyRwnuoJ-va7bykD+q-d-hW-6NsoShoDNyf8CwFw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
	by gabe.freedesktop.org (Postfix) with ESMTP id AA8B1F020B
	for <intel-gfx@lists.freedesktop.org>;
	Fri,  1 Nov 2013 02:00:13 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAKMK7uHYpRsyRwnuoJ-va7bykD+q-d-hW-6NsoShoDNyf8CwFw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Nov 01, 2013 at 09:54:39AM +0100, Daniel Vetter wrote:
> On Fri, Nov 1, 2013 at 9:38 AM,  <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> >
> > i915 depends on CONFIG_AGP and CONFIG_AGP_INTEL. Since AGP is a thing
> > of the past, it's somewhat likely that a user would not realize that
> > they need to enable those to get i915. So let's just select CONFIG_AGP
> > and CONFIG_AGP_INTEL instead of depending on them.
> >
> > Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> =

> We don't actually need agp, at least for the kms driver. So I'd go the
> other direction and make it fully optional. UMS won't work if someone
> misconfigures their kernel, but meh.

Don't we still need the AGP backend code for GTT frobbing on older gens?

-- =

Ville Syrj=E4l=E4
Intel OTC