From: Mike Snitzer <snitzer@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Kent Overstreet <kmo@daterainc.com>, linux-kernel@vger.kernel.org
Subject: stec skd block driver needs updating for immutable biovec
Date: Fri, 1 Nov 2013 11:43:39 -0400 [thread overview]
Message-ID: <20131101154338.GA23501@redhat.com> (raw)
In-Reply-To: <5273C2B8.5030608@kernel.dk>
Hey Jens and Kent,
You're likely already aware of this but building the latest
linux-block.git 'for-next' I get:
CC [M] drivers/block/skd_main.o
drivers/block/skd_main.c: In function ‘skd_request_fn’:
drivers/block/skd_main.c:773: error: ‘struct bio’ has no member named ‘bi_sector’
drivers/block/skd_main.c: In function ‘skd_end_request_bio’:
drivers/block/skd_main.c:1142: error: ‘struct bio’ has no member named ‘bi_sector’
drivers/block/skd_main.c: In function ‘skd_preop_sg_list_bio’:
drivers/block/skd_main.c:1198: error: implicit declaration of function ‘bio_iovec_idx’
drivers/block/skd_main.c:1198: warning: assignment makes pointer from integer without a cast
drivers/block/skd_main.c: In function ‘skd_log_skreq’:
drivers/block/skd_main.c:5814: error: ‘struct bio’ has no member named ‘bi_sector’
make[2]: *** [drivers/block/skd_main.o] Error 1
make[1]: *** [drivers/block] Error 2
make: *** [drivers] Error 2
All the bi_sector ones are low hanging fruit, but the conversion for
skd_preop_sg_list_bio()'s bio_vec code is more involved.
Kent, any chance you could crank through it?
If not I can come back to trying to fix this later.. but I'm working
through a test merge of linux-dm.git's 'for-next' with linux-block.git's
'for-next'.
(I happen to have one of these stec cards so I'll be able to test)
Mike
next prev parent reply other threads:[~2013-11-01 15:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 13:59 [PATCH for-next] dm: fix missing bi_remaining accounting Mike Snitzer
2013-11-01 15:03 ` Jens Axboe
2013-11-01 15:43 ` Mike Snitzer [this message]
2013-11-01 15:50 ` stec skd block driver needs updating for immutable biovec Christoph Hellwig
2013-11-01 16:02 ` Jens Axboe
2013-11-01 16:28 ` Mike Snitzer
2013-11-01 16:34 ` Jens Axboe
2013-11-01 17:46 ` Mike Snitzer
2013-11-04 11:25 ` Bartlomiej Zolnierkiewicz
2013-11-04 15:06 ` [PATCH for-next] dm: fix missing bi_remaining accounting Mikulas Patocka
2013-11-04 15:20 ` Mike Snitzer
2013-11-04 15:25 ` Mikulas Patocka
2013-11-04 16:04 ` Mike Snitzer
2013-11-04 17:49 ` Mikulas Patocka
2013-11-05 0:56 ` Mike Snitzer
2013-11-04 20:12 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131101154338.GA23501@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@kernel.dk \
--cc=kmo@daterainc.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.