From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kristian =?iso-8859-1?Q?H=F8gsberg?= Subject: Re: [PATCH 4/6] dri/intel: Add intel_fd_for_region Date: Fri, 1 Nov 2013 10:58:02 -0700 Message-ID: <20131101175802.GC2445@tokamak.local> References: <1383261196-25093-1-git-send-email-keithp@keithp.com> <1383261196-25093-5-git-send-email-keithp@keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-pd0-f176.google.com (mail-pd0-f176.google.com [209.85.192.176]) by gabe.freedesktop.org (Postfix) with ESMTP id E450CF0745 for ; Fri, 1 Nov 2013 10:58:06 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1383261196-25093-5-git-send-email-keithp@keithp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Keith Packard Cc: mesa3d-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Thu, Oct 31, 2013 at 04:13:14PM -0700, Keith Packard wrote: > Returns a prime file descriptor for the specified region. > = > Signed-off-by: Keith Packard > --- > src/mesa/drivers/dri/i915/intel_regions.c | 13 +++++++++++++ > src/mesa/drivers/dri/i915/intel_regions.h | 4 ++++ > src/mesa/drivers/dri/i965/intel_regions.c | 13 +++++++++++++ > src/mesa/drivers/dri/i965/intel_regions.h | 4 ++++ > 4 files changed, 34 insertions(+) Makes sense. We should use that in intel_query_image() instead of calling drm_intel_bo_gem_export_to_prime() directly on image->region->bo. Reviewed-by: Kristian H=F8gsberg > diff --git a/src/mesa/drivers/dri/i915/intel_regions.c b/src/mesa/drivers= /dri/i915/intel_regions.c > index 9f5b89e..bac997d 100644 > --- a/src/mesa/drivers/dri/i915/intel_regions.c > +++ b/src/mesa/drivers/dri/i915/intel_regions.c > @@ -238,6 +238,19 @@ intel_region_alloc_for_fd(struct intel_screen *scree= n, > return region; > } > = > +int > +intel_fd_for_region(struct intel_screen *screen, > + struct intel_region *region) > +{ > + int fd; > + int ret; > + > + ret =3D drm_intel_bo_gem_export_to_prime(region->bo, &fd); > + if (ret < 0) > + return ret; > + return fd; > +} > + > void > intel_region_reference(struct intel_region **dst, struct intel_region *s= rc) > { > diff --git a/src/mesa/drivers/dri/i915/intel_regions.h b/src/mesa/drivers= /dri/i915/intel_regions.h > index 6bc4a42..84c013a 100644 > --- a/src/mesa/drivers/dri/i915/intel_regions.h > +++ b/src/mesa/drivers/dri/i915/intel_regions.h > @@ -93,6 +93,10 @@ intel_region_alloc_for_fd(struct intel_screen *screen, > GLuint width, GLuint height, GLuint pitch, > GLuint size, int fd, const char *name); > = > +int > +intel_fd_for_region(struct intel_screen *screen, > + struct intel_region *region); > + > bool > intel_region_flink(struct intel_region *region, uint32_t *name); > = > diff --git a/src/mesa/drivers/dri/i965/intel_regions.c b/src/mesa/drivers= /dri/i965/intel_regions.c > index 3920f4f..2e70326 100644 > --- a/src/mesa/drivers/dri/i965/intel_regions.c > +++ b/src/mesa/drivers/dri/i965/intel_regions.c > @@ -238,6 +238,19 @@ intel_region_alloc_for_fd(struct intel_screen *scree= n, > return region; > } > = > +int > +intel_fd_for_region(struct intel_screen *screen, > + struct intel_region *region) > +{ > + int fd; > + int ret; > + > + ret =3D drm_intel_bo_gem_export_to_prime(region->bo, &fd); > + if (ret < 0) > + return ret; > + return fd; > +} > + > void > intel_region_reference(struct intel_region **dst, struct intel_region *s= rc) > { > diff --git a/src/mesa/drivers/dri/i965/intel_regions.h b/src/mesa/drivers= /dri/i965/intel_regions.h > index 05dfef3..f471b94 100644 > --- a/src/mesa/drivers/dri/i965/intel_regions.h > +++ b/src/mesa/drivers/dri/i965/intel_regions.h > @@ -95,6 +95,10 @@ intel_region_alloc_for_fd(struct intel_screen *screen, > GLuint size, > int fd, const char *name); > = > +int > +intel_fd_for_region(struct intel_screen *screen, > + struct intel_region *region); > + > bool > intel_region_flink(struct intel_region *region, uint32_t *name); > = > -- = > 1.8.4.2 > = > = > -------------------------------------------------------------------------= ----- > Android is increasing in popularity, but the open development platform th= at > developers love is also attractive to malware creators. Download this whi= te > paper to learn more about secure code signing practices that can help keep > Android apps secure. > http://pubads.g.doubleclick.net/gampad/clk?id=3D65839951&iu=3D/4140/ostg.= clktrk > -- > _______________________________________________ > Dri-devel mailing list > Dri-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/dri-devel > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel