From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Tejun Heo <tj@kernel.org>, Kay Sievers <kay@vrfy.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH driver-core-next] sysfs: use generic_file_llseek() for sysfs_file_operations
Date: Fri, 1 Nov 2013 19:40:36 +0100 [thread overview]
Message-ID: <20131101184036.GA3597@osiris> (raw)
In-Reply-To: <20131101171913.GA2241@kroah.com>
On Fri, Nov 01, 2013 at 10:19:13AM -0700, Greg Kroah-Hartman wrote:
> On Fri, Nov 01, 2013 at 01:16:53PM -0400, Tejun Heo wrote:
> > Hey, Greg.
> >
> > Here's proper patch with description and SOB. I'll be traveling from
> > tomorrow so I might not be responsive for some days. Can you please
> > apply it once Heiko confirms it fixes the issue?
>
> Will do.
>
> Heiko, let me know if this fixes your problem or not, thanks.
Yes it does fix the problem. strace output looks like before:
[pid 2495] open("/sys/class/net/eth0/broadcast", O_RDONLY) = 5
[pid 2495] lseek(5, 0, SEEK_END) = 4096
[pid 2495] lseek(5, 0, SEEK_SET) = 0
[pid 2495] read(5, "ff:ff:ff:ff:ff:ff\n", 4096) = 18
[pid 2495] close(5) = 0
Tested-by: Heiko Carstens <heiko.carstens@de.ibm.com>
prev parent reply other threads:[~2013-11-01 18:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 11:43 [BUG -next] sysfs change breaks userspace Heiko Carstens
2013-10-31 17:25 ` Tejun Heo
2013-11-01 14:13 ` Heiko Carstens
2013-11-01 14:35 ` Tejun Heo
2013-11-01 15:04 ` Greg Kroah-Hartman
2013-11-01 15:08 ` Tejun Heo
2013-11-01 16:14 ` Greg Kroah-Hartman
2013-11-01 17:16 ` [PATCH driver-core-next] sysfs: use generic_file_llseek() for sysfs_file_operations Tejun Heo
2013-11-01 17:19 ` Greg Kroah-Hartman
2013-11-01 18:40 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131101184036.GA3597@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=kay@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.