From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator. Date: Fri, 1 Nov 2013 11:50:45 -0700 Message-ID: <20131101185045.GG2493@sirena.org.uk> References: <1383289495-24523-1-git-send-email-Li.Xiubo@freescale.com> <1383289495-24523-6-git-send-email-Li.Xiubo@freescale.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="W0QGcccuECrPGiFB" Return-path: Content-Disposition: inline In-Reply-To: <1383289495-24523-6-git-send-email-Li.Xiubo@freescale.com> Sender: linux-doc-owner@vger.kernel.org To: Xiubo Li Cc: r65073@freescale.com, timur@tabi.org, lgirdwood@gmail.com, r64188@freescale.com, rob.herring@calxeda.com, pawel.moll@arm.com, mark.rutland@arm.com, swarren@wwwdotorg.org, ian.campbell@citrix.com, rob@landley.net, linux@arm.linux.org.uk, perex@perex.cz, tiwai@suse.de, grant.likely@linaro.org, fabio.estevam@freescale.com, LW@KARO-electronics.de, oskar@scara.com, shawn.guo@linaro.org, b42378@freescale.com, b18965@freescale.com, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org List-Id: alsa-devel@alsa-project.org --W0QGcccuECrPGiFB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 01, 2013 at 03:04:52PM +0800, Xiubo Li wrote: > On VF610 series there are no regulators used, and now whether the > CONFIG_REGULATOR mirco is enabled or not, for the VF610 audio > patch series, the board cannot be probe successfully. > And this patch will solve this issue. I don't understand what this is for at all, you're just saying there is a problem you're trying to solve but you don't explain anything about what the problem is or how your changes address it. > +#ifndef CONFIG_SND_SOC_FSL_SGTL5000_VF610 > static int ldo_regulator_register(struct snd_soc_codec *codec, This is definitely broken, it won't work with multi-platform kernels, and I don't understand what this is supposed to do - what is the reason for making this change? --W0QGcccuECrPGiFB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSc/gBAAoJELSic+t+oim9Nt4P/RNfAEEOA7DMMZvrmhAOlI0I 9G5EyWOsbCUGOMOjwDMp/DY3i06MjBFY+HskbGTLpCWwdLGDSKP13mTR2duksur6 PN4GJTPrcba7U6BRKnZrXuWQYRg/VRaJiVY0uSYdhhm1rH0IzEM+i+tWC77AzLWG 9ZNxTwwVfXo2ZNStmewW6VqxtvV9K44UvpSXOw8pM+2p6cdEfMtUtdaSs6khFI3/ OBil5mdkAAfWL3MLiiXvTyaJNGVoxlaqSlWBcgbWvHtrmXvgqqIuCoV0tnqpg/Cm 5DuOsSwYYjpaM5vwm9YDG7ubdEMDoJybJds2qjh5RZV4FEaw2mx/lve2ZdoN3xyX x0jBTPsBbLIkOp/3qbsAkHDwcXneVwnnVmbD9dKVCOkI3Fg9kjksX+gbR9Inohrl 7JTZWASuCVPMQvFSDH6yQvsZCsZrVT6vTfCJL/iBx9UwpkdYCWXyKj/E+fwH3r44 UHL1JK2a4qVlJiIJ98l3AUJ0FkuJuEt+qnKQe2OQKajlgV8mr+YTKBFNNOiJTBN8 YDFCGymYN8FTKjTCvGobe++mu1UESawUrVghlxgPtCbzqWQEg+oTVddQszYoDmpd o2tdV1rtVwWOov1AOcYUTKivdH1DbFD6uJjRnif6pL8dlhDX3wlVs3G14UAeQjBE N6ZZ9FKNT50SjIPKU/0R =rxDU -----END PGP SIGNATURE----- --W0QGcccuECrPGiFB-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cassiel.sirena.org.uk (unknown [IPv6:2001:41c8:1:5384::2]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 880962C00D0 for ; Sat, 2 Nov 2013 05:51:53 +1100 (EST) Date: Fri, 1 Nov 2013 11:50:45 -0700 From: Mark Brown To: Xiubo Li Message-ID: <20131101185045.GG2493@sirena.org.uk> References: <1383289495-24523-1-git-send-email-Li.Xiubo@freescale.com> <1383289495-24523-6-git-send-email-Li.Xiubo@freescale.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="W0QGcccuECrPGiFB" In-Reply-To: <1383289495-24523-6-git-send-email-Li.Xiubo@freescale.com> Subject: Re: [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator. Cc: mark.rutland@arm.com, alsa-devel@alsa-project.org, linux-doc@vger.kernel.org, tiwai@suse.de, b18965@freescale.com, timur@tabi.org, perex@perex.cz, r65073@freescale.com, LW@KARO-electronics.de, linux@arm.linux.org.uk, b42378@freescale.com, linux-arm-kernel@lists.infradead.org, grant.likely@linaro.org, devicetree@vger.kernel.org, ian.campbell@citrix.com, pawel.moll@arm.com, swarren@wwwdotorg.org, rob.herring@calxeda.com, oskar@scara.com, fabio.estevam@freescale.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, rob@landley.net, r64188@freescale.com, shawn.guo@linaro.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --W0QGcccuECrPGiFB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 01, 2013 at 03:04:52PM +0800, Xiubo Li wrote: > On VF610 series there are no regulators used, and now whether the > CONFIG_REGULATOR mirco is enabled or not, for the VF610 audio > patch series, the board cannot be probe successfully. > And this patch will solve this issue. I don't understand what this is for at all, you're just saying there is a problem you're trying to solve but you don't explain anything about what the problem is or how your changes address it. > +#ifndef CONFIG_SND_SOC_FSL_SGTL5000_VF610 > static int ldo_regulator_register(struct snd_soc_codec *codec, This is definitely broken, it won't work with multi-platform kernels, and I don't understand what this is supposed to do - what is the reason for making this change? --W0QGcccuECrPGiFB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSc/gBAAoJELSic+t+oim9Nt4P/RNfAEEOA7DMMZvrmhAOlI0I 9G5EyWOsbCUGOMOjwDMp/DY3i06MjBFY+HskbGTLpCWwdLGDSKP13mTR2duksur6 PN4GJTPrcba7U6BRKnZrXuWQYRg/VRaJiVY0uSYdhhm1rH0IzEM+i+tWC77AzLWG 9ZNxTwwVfXo2ZNStmewW6VqxtvV9K44UvpSXOw8pM+2p6cdEfMtUtdaSs6khFI3/ OBil5mdkAAfWL3MLiiXvTyaJNGVoxlaqSlWBcgbWvHtrmXvgqqIuCoV0tnqpg/Cm 5DuOsSwYYjpaM5vwm9YDG7ubdEMDoJybJds2qjh5RZV4FEaw2mx/lve2ZdoN3xyX x0jBTPsBbLIkOp/3qbsAkHDwcXneVwnnVmbD9dKVCOkI3Fg9kjksX+gbR9Inohrl 7JTZWASuCVPMQvFSDH6yQvsZCsZrVT6vTfCJL/iBx9UwpkdYCWXyKj/E+fwH3r44 UHL1JK2a4qVlJiIJ98l3AUJ0FkuJuEt+qnKQe2OQKajlgV8mr+YTKBFNNOiJTBN8 YDFCGymYN8FTKjTCvGobe++mu1UESawUrVghlxgPtCbzqWQEg+oTVddQszYoDmpd o2tdV1rtVwWOov1AOcYUTKivdH1DbFD6uJjRnif6pL8dlhDX3wlVs3G14UAeQjBE N6ZZ9FKNT50SjIPKU/0R =rxDU -----END PGP SIGNATURE----- --W0QGcccuECrPGiFB-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@kernel.org (Mark Brown) Date: Fri, 1 Nov 2013 11:50:45 -0700 Subject: [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator. In-Reply-To: <1383289495-24523-6-git-send-email-Li.Xiubo@freescale.com> References: <1383289495-24523-1-git-send-email-Li.Xiubo@freescale.com> <1383289495-24523-6-git-send-email-Li.Xiubo@freescale.com> Message-ID: <20131101185045.GG2493@sirena.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Nov 01, 2013 at 03:04:52PM +0800, Xiubo Li wrote: > On VF610 series there are no regulators used, and now whether the > CONFIG_REGULATOR mirco is enabled or not, for the VF610 audio > patch series, the board cannot be probe successfully. > And this patch will solve this issue. I don't understand what this is for at all, you're just saying there is a problem you're trying to solve but you don't explain anything about what the problem is or how your changes address it. > +#ifndef CONFIG_SND_SOC_FSL_SGTL5000_VF610 > static int ldo_regulator_register(struct snd_soc_codec *codec, This is definitely broken, it won't work with multi-platform kernels, and I don't understand what this is supposed to do - what is the reason for making this change? -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: