From: Aldo Iljazi <mail@aldo.io>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: marek.belisko@gmail.com, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: ft1000: fixed coding style issues
Date: Sun, 3 Nov 2013 10:18:11 +0200 [thread overview]
Message-ID: <20131103081811.GA7025@linux> (raw)
In-Reply-To: <20131103063049.GI26669@mwanda>
Dan Carpenter wrote:
> On Sat, Nov 02, 2013 at 11:18:20PM +0200, Aldo Iljazi wrote:
> > Aldo Iljazi wrote:
> >
> > > Fixed a few coding style issues that checkpatch reported.
> > >
> > > Specifically:
> > >
> > > 1. line over 80 characters issue on the lines 9 and 10.
> > > 2. space prohibited before open square bracket '[' issue on the lines
> > > 31.
> > > 3. inserted space after comma on lines 32 to 156.
> > >
> > > Signed-off-by: Aldo Iljazi <mail@aldo.io>
>
> This file is easy to review so you may as well fix all the issues.
>
> Clean up the license block so it's in the normal format. Put the commas
> at the end of the line instead of the beginning.
>
> regards,
> dan carpenter
>
Okay I'll resend later.
--
Aldo Iljazi
next prev parent reply other threads:[~2013-11-03 8:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-02 21:03 [PATCH] Staging: ft1000: fixed coding style issues Aldo Iljazi
2013-11-02 21:18 ` Aldo Iljazi
2013-11-03 6:30 ` Dan Carpenter
2013-11-03 8:18 ` Aldo Iljazi [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-11-10 13:44 Aldo Iljazi
2013-11-02 20:55 Aldo Iljazi
2013-11-02 20:47 Aldo Iljazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131103081811.GA7025@linux \
--to=mail@aldo.io \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.