All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <jhovold@gmail.com>
To: Colin Leitner <colin.leitner@googlemail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-serial@vger.kernel.org,
	linux-usb mailing list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] pl2303: fixed handling of CS5 setting. 5 databits work now
Date: Sun, 3 Nov 2013 18:13:56 +0100	[thread overview]
Message-ID: <20131103171356.GD32672@localhost> (raw)
In-Reply-To: <CAMgPeKVinmcB7sDaTjU4LCA_AUY3QnxqoENBOmKsbpvk+9tDRw@mail.gmail.com>

On Sun, Nov 03, 2013 at 06:11:23PM +0100, Johan Hovold wrote:

> >> +       switch (C_CSIZE(tty)) {
> >> +       case CS5:
> >> +               buf[6] = 5;
> >> +               break;
> >> +       case CS6:
> >> +               buf[6] = 6;
> >> +               break;
> >> +       case CS7:
> >> +               buf[6] = 7;
> >> +               break;
> >> +       default:
> >
> > You can drop the default-case as CSIZE is a two-bit mask.

Nevermind. Just leave it there to keep gcc happy.

Thanks,
Johan

> +       case CS8:
> +               buf[6] = 8;
>         }

  parent reply	other threads:[~2013-11-03 17:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-03 14:47 [PATCH] pl2303: fixed handling of CS5 setting. 5 databits work now Colin Leitner
2013-11-03 17:04 ` Johan Hovold
     [not found]   ` <CAMgPeKVinmcB7sDaTjU4LCA_AUY3QnxqoENBOmKsbpvk+9tDRw@mail.gmail.com>
2013-11-03 17:13     ` Johan Hovold [this message]
2013-11-03 21:54   ` Colin Leitner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131103171356.GD32672@localhost \
    --to=jhovold@gmail.com \
    --cc=colin.leitner@googlemail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.